On Thu, Mar 26, 2015 at 5:36 AM, Mark Wielaard <mjw(a)redhat.com> wrote:
On Wed, 2015-03-25 at 09:37 -0700, H.J. Lu wrote:
> Here is the updated patch. Testcases will be sent separately.
Looks good, only one tiny nitpick:
> --- a/backends/linux-core-note.c
> +++ b/backends/linux-core-note.c
> @@ -1,5 +1,5 @@
> /* Common core note type descriptions for Linux.
> - Copyright (C) 2007-2010 Red Hat, Inc.
> + Copyright (C) 2007-2015 Red Hat, Inc.
> --- a/backends/x86_64_corenote.c
> +++ b/backends/x86_64_corenote.c
> @@ -1,5 +1,5 @@
> /* x86-64 specific core note handling.
> - Copyright (C) 2005, 2007, 2008 Red Hat, Inc.
> + Copyright (C) 2005, 2007, 2008, 2015 Red Hat, Inc.
> --- a/backends/x86_64_init.c
> +++ b/backends/x86_64_init.c
> @@ -1,5 +1,5 @@
> /* Initialization of x86-64 specific backend library.
> - Copyright (C) 2002-2009, 2013 Red Hat, Inc.
> + Copyright (C) 2002-2009, 2013, 2015 Red Hat, Inc.
I assume you didn't do this work under contract of Red Hat. We only
require a Signed-Off-By as described in the CONTRIBUTING file. There is
no transfer of copyright. So just add the Signed-off-by to the commit
when agreeing to the Developer's Certificate of Origin. And for each
file just add a copyright line mentioning who you did the work for e.g.
Copyright (C) 2015, Intel Corporation.
Do we need "Copyright (C) 2015, Intel Corporation"? Intel doesn't
claim/have copyright on those files I added, especially those files
I copied/modified from the existing ones.
--
H.J.