On Wed, 2015-10-21 at 16:11 -0700, Chih-hung Hsieh wrote:
+2015-10-21 Chih-Hung Hsieh <chh(a)google.com>
+
+ * dwfl_module.c (dwfl_report_module): Move nested function 'use' to file
+ scope.
+ * dwfl_module_getsrc_file.c (dwfl_module_getsrc_file): Move nested functions
+ 'dwarf_line_file', 'dwfl_line', and 'dwfl_line_file' to file
scope.
I pushed only the dwfl_module.c change (as attached) to master.
Although the dwfl_module_getsrc_file.c change itself is good, the abuse
of INTUSE to define and use a "not really" libdw dwarf_line_file
function (which really is just dwarf_linesrc with the two unused return
values dropped) was just too ugly. Sorry, I know you didn't introduce
this (it looks like it has been this way forever). I'll propose
something that doesn't hurt my eyes so much.
Thanks,
Mark