On 08/16/2012 01:49 PM, Roland McGrath wrote:
We don't touch elf.h directly, we only copy it verbatim from glibc.
I've done that update.

Your changes need ChangeLog entries.

You don't need to quote the contribution agreement in your commit message,
just the -s (Signed-off-by line) is enough.

Your new files have the wrong copyright terms.
Please follow the model of the existing files in the git repository.

Please cite 'make check' results on a native build.
You also need to add tilegx cases to run-allregs.sh and perhaps others.

In backends/*_regs.c note how we have mostly avoided tables of string
pointers, because these necessitate dynamic relocs for the pointers.
That's not a problem with string constants used directly in code.


Thanks,
Roland

No problem.  Would you like those fixes relative to what I just sent, or should I do it clean from the current git tree?

Thanks.