On 08/21/2012 08:11 AM, Mark Wielaard wrote:
On Mon, 2012-08-20 at 11:37 -0400, Jeff Kenton wrote:
2. Changelog:

   backends/
     *Makefile.am: added tilegx processor.
     *tilegx_corenote.c: new file.
     *tilegx_regs.c: new file.
     *tilegx_reloc.def: new file.
     *tilegx_init.c: new file.
     *tilegx_retval.c: new file.
     *tilegx_symbol.c: new file.
   libebl/
     *eblopenbackend.c: added tilegx processor.
   src/
     *elflint.c: added tilegx processor.
   tests/
     *run-allregs.sh: added testfile60 for tilegx processor.
     *testfile60.bz2: new file.
Please just include those in the ChangeLog files. It should look
something like the attached ChangeLog.diff.

1 of 88 tests failed
So that is the only failure. Good.

-## Copyright (C) 2000-2010 Red Hat, Inc.
+## Copyright (C) 2000-2012 Red Hat, Inc.
You should add a correct Copyright line. You/Tilera made the changes and
so holds copyright on them. Please add a new Copyright line just after
this line with the current year and the copyright holder. In new files
you write from scratch just have only you/Tilera as copyright holder.

+#if 0
+ssize_t
+arm_register_info (Ebl *ebl __attribute__ ((unused)),
+                  int regno, char *name, size_t namelen,
+                  const char **prefix, const char **setname,
+                  int *bits, int *type)
+{
+  switch (regno)
+    {
+    case 13 ... 15:
+      *type = DW_ATE_address;
+      name[0] = "slp"[regno - 13];
+      name[1] = "prc"[regno - 13];
+      namelen = 2;
+      break;
+
+    case 128:
+      *type = DW_ATE_unsigned;
+      return stpcpy (name, "spsr") + 1 - name;
+    }
+
+  name[namelen++] = '\0';
+  return namelen;
+}
+#endif
That should not be there.

Thanks,

Mark

Done.  New patch attached.

Thanks.

--jeff kenton