On Wed, 2013-01-23 at 19:04 +0100, Jan Kratochvil wrote:
But I find it messy a bit, You adjust AUX_SYMENTS for that initial
symbol but you do not adjust AUX_FIRST_GLOBAL for that initial zero symbol.
Therefore AUX_SYMENTS and AUX_FIRST_GLOBAL numbering is off-by-one.
I would prefer to not modify the member variable AUX_SYMENTS and only adjust
it if needed / when read, as you already do with AUX_FIRST_GLOBAL.
You are right, that is nicer. And aux_syments is really only used in one
place. Updated patch that only adjusts at use attached.
TBH FYI / no request here: I no not find this first_global + syments
now when combining multiple symbol tables, which is why I have refactored it in:
[patch 1/3] ppc64 .opd: Refactor syments/first_global
I'll take a look. I should be somewhat familiar with the code now.
BTW. Please do ping patches you feel are urgent.