On Tue, 2013-10-29 at 21:06 +0100, Jan Kratochvil wrote:
currently dwfl->executable_for_core is private. It is set from
libdwfl/argp-std.c but it is used also from libdwfl/link_map.c.
Applications not using dwfl_standard_argp () cannot use executable_for_core.
2013-10-29 Jan Kratochvil <jan.kratochvil(a)redhat.com>
* argp-std.c (parse_opt): Use executable parameter of
* core-file.c (dwfl_core_file_report): Add parameter executable. Set
it to DWFL. Add NEW_VERSION for it.
(_compat_without_executable_dwfl_core_file_report): New. Twice.
* libdwfl.h (dwfl_core_file_report): Add parameter executable, update
the function comment.
This looks like a good thing to have. Change and new documentation look
good. I would have liked to also keep source compatibility (and I would
have just introduced a new function), but looking around I couldn't find
any users of this function. I presume everything did just use the
dwfl_standard_argp way. So since it does preserve binary compatibility I
think the change is OK.