On 29 Jul 2003, Harald Hoyer wrote:
I wanted to modify CXXFLAGS and stumbled across the %configure definition... CFLAGS="${CFLAGS:-%optflags}" CXXFLAGS="${CXXFLAGS:-%optflags}" FFLAGS="${FFLAGS:-%optflags}"
Wouldn't it be better to have this in /usr/lib/rpm/redhat/macros:
RPM_OPT_FLAGS="%{optflags}"
This part already happens automatically and is unnecessary.
CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" CXXFLAGS="${CXXFLAGS:-${RPM_OPT_FLAGS}}" FFLAGS="${FFLAGS:-${RPM_OPT_FLAGS}}"
so that I can modify RPM_OPT_FLAGS prior to calling %configure??
If it is safe to assume that $RPM_OPT_FLAGS is only ever used in %build, then please commit the change to redhat-rpm-config in devel CVS, and build the update into dist-3.0E and dist-10.
-- Elliot Humpty Dumpty was pushed.
On Tue, 2003-07-29 at 18:41, Elliot Lee wrote:
CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" CXXFLAGS="${CXXFLAGS:-${RPM_OPT_FLAGS}}" FFLAGS="${FFLAGS:-${RPM_OPT_FLAGS}}"
so that I can modify RPM_OPT_FLAGS prior to calling %configure??
If it is safe to assume that $RPM_OPT_FLAGS is only ever used in %build, then please commit the change to redhat-rpm-config in devel CVS, and build the update into dist-3.0E and dist-10.
Note that a lot of packages exist that do things like
perl -pi -e "s|-O2|$RPM_OPT_FLAGS|" Makefile
in %prep. Dunno about the effects, but just pointing out that $RPM_OPT_FLAGS is sometimes used outside of %build.
(Yep, it would be better to do 's|-O2|$(RPM_OPT_FLAGS)|' or something else that doesn't use the actual value of $RPM_OPT_FLAGS at the time the perl/sed'ing occurs).
-
Elliot Lee -
Ville Skyttä