On 12/29/2016 11:23 AM, Michael Schwendt wrote:
It may be necessary to debug the cmake libclaw detection script.
claw-config is broken, btw, and it's likely that this has not been
caught during review:
$ claw-config --libs
-L/usr/lib
$ claw-config application --libs
-L/usr/lib -lclaw_application -lclaw_logger
$ claw-config dynamic_library --libs
-L/usr/lib -lclaw_dynamic_library -ldl
Wrong on x86_64.
And odd to relink with libdl as libclaw_dynamic_library is linked with
libdl already.
$ claw-config all --libs
-L/usr/lib -lclaw_application -lclaw_logger -lclaw_dynamic_library -ldl
-lclaw_configuration_file -lclaw_graphic -lpng -lz -ljpeg -lclaw_logger
-lclaw_net -lclaw_tween
Is relinking with all those non-libclaw libs necessary? It seems they are
for linking statically only.
$ claw-config --cflags
-I/usr/include/ -DCLAW_JPEG_SUPPORT -DCLAW_PNG_SUPPORT
This -I parameter is not only superfluous (because /usr/include is
standard search path), but may also be harmful, since it alters the
search order.
Further packaging issues:
$ rpmls libclaw|grep claw1
drwxr-xr-x /usr/share/doc/libclaw1
-rw-r--r-- /usr/share/doc/libclaw1/COPYING
Why "libclaw1" and not %name?
No %license usage.
_______________________________________________
devel mailing list -- devel(a)lists.fedoraproject.org
To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
I've hopefully fixed most of these issues including the initial cmake issue
with this build:
* Thu Dec 29 2016 Orion Poplawski <orion(a)cora.nwra.com> - 1.7.4-16
- Install cmake files in arch specific dirs
- Put documentation into separate noarch sub-package
- Require needed devel packages in -devel sub-package
- Use %license
https://koji.fedoraproject.org/koji/taskinfo?taskID=17109344
I did not address the various -l library output of claw-config or
-I/usr/include, nor the "libclaw1" name.
Initial issue was caused by the claw cmake file refusing to "find" libclaw if
any of the dependent packages (libjpeg/libpng/boost) were not found.
libclaw-devel now requires them.
--
Orion Poplawski
Technical Manager 720-772-5637
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane orion(a)nwra.com
Boulder, CO 80301
http://www.nwra.com