On Mon, Aug 27, 2018 at 8:33 PM Scott Talbert <swt(a)techie.net> wrote:
I'm not the maintainer of this package (iaxclient), but I ran
build failure while working on a pull request. It seems to be fallout
from the -Wl,--as-needed change. Any idea why this is happening?
Who started this trend of ignoring the libtool script generated by
configure and using /usr/bin/libtool instead? I've run across several
spec files in the last few days that do that. It isn't right. The
configure script tailors the generated libtool in various ways. Try
the attached spec file, which works much better.
Also, this gcc warning is warning about a real bug:
BUILDSTDERR: md5.c: In function 'MD5Final':
BUILDSTDERR: md5.c:180:26: warning: argument to 'sizeof' in 'memset'
call is the same expression as the destination; did you mean to
dereference it? [-Wsizeof-pointer-memaccess]
BUILDSTDERR: memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */
Yep, that should be memset(ctx, 0, sizeof(*ctx));
The attached spec file also fixes mixed use of tabs and spaces, and
uses %ldconfig_scriptlets in place of explicit ldconfig invocations.