On Tue, Mar 02, 2004 at 08:30:41PM +0200, Kaj J. Niemi wrote:
> %post/%postun, and there were a few too many RFCs in %doc for my
taste.
Ok.
> RPM_OPT_FLAGS doesn't seem to be actually used during the build AFAICT.
True. Make type lnp actually uses RPM_OPT_FLAGS as BASECFLAGS but I don't
think it's being used anywhere in c-client. Diff to yours below.
Great, thanks... $RPM_OPT_FLAGS really should be used though. I fear
this is going to break horribly on one of the platforms when I submit
it. Another issue, it links the .so using:
ld -shared -x -soname libc-client.so.0 -o libc-client.so.0 osdep.so ...
which is bad, it should use "gcc -shared -Wl,-soname" at least.
Current spec attached again with a new patch for an unrelated issue I
spotted the other day on FC1.
Regards,
joe