On 16 March 2017 at 18:01, Jan Kratochvil <jkratoch@redhat.com> wrote:
On Thu, 16 Mar 2017 01:32:06 +0100, Tomasz Kłoczko wrote:
> OK here is full list of spec files which have glibc-static in BuildRequires:
>
> ./g/gdb.git/gdb.spec:BuildRequires: glibc-static%{bits_local}
This is a false positive as it is enclosed by:
%if 0%{?_with_testsuite:1}
I have no idea how common it may be but your grep could check %ifs.
I saw already such tweaks in many Fedora specs %check sections.
IMO such %ifing inside or around %check is incorrect/not needed and can be removed.
Why? Because:
- all possible to use package tests should be by default enabled
- if rpm packager want to speedup generate binary packages avoiding execution of %check section it is already possible to do this without spec file %ifing by use --nocheck rpmbuild option.
However IMO still few things are missing in whole %check framework: