On Mon, 21 May 2007 16:40:16 +0100
Paul Nasrat <pnasrat(a)redhat.com> wrote:
On Fri, 2007-05-18 at 11:58 -0700, Toshio Kuratomi wrote:
> It's a bug in rpm. Namely, these lines from ogre.spec
are throwing
> things off:
> %exclude %{_bindir}/Ogre-Samples
> %exclude %{_libdir}/OGRE/Samples
> %exclude %{_datadir}/OGRE/Samples
>
> Rpm's size calculation doesn't properly handle
%exclude.
Hmm we should be:
Patch13: rpm-4.4.2-excluded-size.patch
--- rpm-4.4.2/build/files.c.excludedsize 2005-11-29
16:21:12.000000000 -0500
+++ rpm-4.4.2/build/files.c 2005-11-29 16:21:21.000000000
-0500
@@ -1678,7 +1678,7 @@
} else
i = fl->fileListRecsUsed;
- if (S_ISREG(flp->fl_mode) && i >= fl->fileListRecsUsed)
+ if (!(flp->flags & RPMFILE_EXCLUDE) &&
S_ISREG(flp->fl_mode) && i >= fl->fileListRecsUsed)
fl->totalFileSize += flp->fl_size;
}
Well,
I can confirm that this does NOT work properly on a recent
rawhide system.
Maybe the problem is that I exclude dirs, and that the size
calculation still dives into the dir, and doesn't see the
files in there as excluded?
Regards,
Hans