On Thu, Sep 26, 2019 at 01:15:03PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
On Thu, Sep 26, 2019 at 03:01:25PM +0200, Remi Collet wrote:
> Le 26/09/2019 à 11:36, Pierre-Yves Chibon a écrit :
> > Here is what the vision we came to and that we would like to discuss:
> >
> > ○ Every changes to dist-git is done via pull-requests
>
> IMHO Have to stay optional, making this mandatory being a terrible headache.
Agreed. *How* commits are pushed to the repo is generally completely
orthogonal to the issue of automatically building stuff based on
commits to the repo. One the one hand, none of the other stuff in the
proposal requires PRs,
If you want to test changes before they are merged PR is the place to do this :)
and on the other hand, this requirement would
break other legitimate workflows: scripted cleanups to small things
(like the recent removal of Group:) that don't merite rebuilding,
scripted management of packages that people do, etc.
If you don't bump the release, the automated build will stop because the NEVR
already exists in koji, so I don't quite see how scripting cleaning up is
impacted by this.
Just like today, you will clone the git repo, edit the master branch and instead
of doing just a git push you'd do a git push fork && open PR and if typing
two
commands is too much we can easily build tooling around this :)
Again, I'd like to reinforce that the idea is not to enforce any part of this
workflow tomorrow, it'll be a smooth, slow and long transition. My question is
whether this is a place where we want to go or can we come up with a
different/better one? :)
Thanks for your input :)
Pierre