On 2018-12-06, Daniel P Berrangé <berrange(a)redhat.com> wrote:
On Thu, Dec 06, 2018 at 02:48:32PM +0000, Petr Pisar wrote:
> On 2018-12-06, Florian Weimer <fweimer(a)redhat.com> wrote:
> > In a sense, it's the old discussion between explicit rename recording
> > and rename detection. I think it's clear by now that rename detection
> > has won.
> >
> Can you give us some example of a rename detection that works?
>
> If a packager cherry-picks patches, he looses upstream's commit IDs.
You should essentially always use 'git cherry-pick -x $HASH' this causes
the commit message to have a line appended:
(cherry picked from commit d6b27d3e4c40946efa79e91d134616b41b1666c4)
I did not know about the -x option. Thanks. I used to ammend the
original commit ID manually.
However, this is essentially the "explicit rename recording" that
Florian claims is not needed anymore.
-- Petr