On Tue, Dec 3, 2019 at 7:28 AM Chris Murphy <lists(a)colorremedies.com> wrote:
Gist is tpm2-abrmd expects to find a TPM2, since it doesn't, it fails
ungracefully and restarts every 5s, thus spamming the journal.
This seems to be fixed in upstream:
I've cherry-picked the upstream patches and shared a tpm2-abrmd
scratch build in the bugzilla for you to test.
I'm not sure if I agree with the upstream solution though, since they
added a RestartPreventExitStatus= option to prevent restarting the
daemon in case of errors that they consider not recoverable. But I
don't understand why they have the Restart=always in the first place,
since the service is D-Bus activated anyways. So I think that all the
restart options should just be removed.
And I also think that the unit file should have a condition to check
if a TPM chardev exists (i.e: ConditionPathExistsGlob=/dev/tpm*) and
don't even attempt to start the service if that's not the case.
I've proposed both changes upstream, let's see what they say.