On Wed, 2009-10-28 at 13:45 +0100, Martin Sourada wrote:
On Wed, 2009-10-28 at 12:35 +0100, Martin Sourada wrote:
> On Mon, 2009-10-26 at 09:48 -0400, Matthias Clasen wrote:
> > On Mon, 2009-10-26 at 13:47 +0100, Martin Sourada wrote:
> >
> > >
> > > I think fixing these would nicely fit with your "polishes for
F12"
> > > project.
> > >
> >
> > Yes, thanks for pointing these out.
> Matthias,
>
> going through the tooltips patch, I found these problems:
> in fill_background():
> + draw_round_rect (cr,
> + 1.0, 1, 1, radius,
> + widget->allocation.width - 2,
> + widget->allocation.height - 2);
> should be
> + draw_round_rect (cr,
> + 1.0, 0.5, 0.5, radius,
> + widget->allocation.width - 1,
> + widget->allocation.height - 1);
So, just built and tested -> this is enough to make it look crisp.
> and in update_shape()
> + draw_round_rect (cr, 1.0, 0, 0, 4, width, height);
> you are ignoring radius setting.
Hrm, this one is hard to get looking good... The best setting I've came
up with is radius + 1 instead of 4.
Thanks for looking into this, Martin.
I'm just building gtk2 and metacity packages that should fix this. Care
to try them out and tell me if they match your quality standards ?
gtk2-2.18.3-13.fc12
metacity-2.28.0-5.fc12
Then I'll have them tagged.