[Bug 1006631] New: New version please
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1006631
Bug ID: 1006631
Summary: New version please
Product: Fedora
Version: rawhide
Component: wxGlade
Assignee: hellwolf.misty(a)gmail.com
Reporter: cickumqt(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: bbbush.yuan(a)gmail.com, hellwolf.misty(a)gmail.com
It has released new version for a long time (0.6.8 now)
Please update, or release your ownership.
--
You are receiving this mail because:
You are watching the reporter of the bug.
10 years, 7 months
[Bug 1002321] Review Request: perl-File-KeePass - Interface to KeePass V1 and V2 database files
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1002321
Eduardo Echeverria <echevemaster(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |fedora-review+
--- Comment #8 from Eduardo Echeverria <echevemaster(a)gmail.com> ---
I will sponsor to Matias, lifting FE-NEEDSPONSOR
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/makerpm/perl/1002321-perl-File-
KeePass/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
* Any pel package that are licensed under the same license of perl are licensed
under both the GPL and Artistic licenses, comment not required
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/perl5/vendor_perl/File(perl-File-BaseDir, perl-Image-ExifTool,
perl-File-DesktopEntry, perl-File-CheckTree, perl-File-MimeInfo, perl-
File-Listing)
* As specified in the general Packaging Guidelines, perl packages are expected
to share ownership of certain directories
http://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00_base.t ..... ok
t/01_kdbx.t ..... ok
t/05_convert.t .. ok
All tests successful.
Files=3, Tests=179, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.63 cusr 0.05
csys = 1.74 CPU)
Result: PASS
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: perl-File-KeePass-2.03-3.fc20.noarch.rpm
perl-File-KeePass-2.03-3.fc20.src.rpm
perl-File-KeePass.noarch: W: spelling-error %description -l en_US kdb -> kb,
db, k db
perl-File-KeePass.noarch: W: spelling-error %description -l en_US kdbx
perl-File-KeePass.src: W: spelling-error %description -l en_US kdb -> kb, db, k
db
perl-File-KeePass.src: W: spelling-error %description -l en_US kdbx
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint perl-File-KeePass
perl-File-KeePass.noarch: W: spelling-error %description -l en_US kdb -> kb,
db, k db
perl-File-KeePass.noarch: W: spelling-error %description -l en_US kdbx
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'
Requires
--------
perl-File-KeePass (rpmlib, GLIBC filtered):
perl(:MODULE_COMPAT_5.18.1)
perl(Crypt::Rijndael)
perl(Digest::SHA)
perl(constant)
perl(strict)
perl(warnings)
Provides
--------
perl-File-KeePass:
perl(File::KeePass)
perl-File-KeePass
Source checksums
----------------
http://www.cpan.org/authors/id/R/RH/RHANDOM/File-KeePass-2.03.tar.gz :
CHECKSUM(SHA256) this package :
c30c688027a52ff4f58cd69d6d8ef35472a7cf106d4ce94eb73a796ba7c7ffa7
CHECKSUM(SHA256) upstream package :
c30c688027a52ff4f58cd69d6d8ef35472a7cf106d4ce94eb73a796ba7c7ffa7
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1002321 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
----------------
PACKAGE APPROVED
----------------
Follow the process from:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Ad...
If you have any questions , feel free to contact me through my email or in the
irc channel #fedora-devel, my nick is echevemaster
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
10 years, 7 months
[Bug 854723] Review Request: bat - Binary Analysis Tool
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=854723
--- Comment #16 from Christopher Meng <cickumqt(a)gmail.com> ---
%{_sysconfdir}/bat is bad.
You should define every conf file is %config(noreplace), just use
%{_sysconfdir}/bat to include them is not enough.
Should be(prototype):
%dir %{_sysconfdir}/bat --> OR %dir %{_sysconfdir}/%{name}, up to you ;)
%config(noreplace) %{_sysconfdir}/bat/a.conf
%config(noreplace) %{_sysconfdir}/bat/b.conf
%config(noreplace) %{_sysconfdir}/bat/c.conf
. .
. .
. .
. .
. .
. .
. .
%config(noreplace) %{_sysconfdir}/bat/n.conf
===========
BuildRequires: python is wrong, should be:
BuildRequires: python2-devel
And missing BuildRequires: python-setuptools
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
10 years, 7 months