On Thu, 2010-06-03 at 16:58 -0400, Mohammed Morsi wrote:
On 06/03/2010 02:39 PM, Scott Seago wrote:
> Tomas Sedovic wrote:
>> ACK with a caveat inline.
>>
>> Also, it would be great if it looked and behaved the same way as the
>> pool-specific instance table does now (using the DataTables jquery
>> thingy).
>>
>> But that can be in another patch and I'm not sure how important it is
>> for now.
>>
>> Thomas
>>
> Actually we probably do want it using the same jquery bits for now, if
> possible.
>
> Scott
Sent an updated patch, with the following changes / caveats:
- the DataTables plugin is now used, albeit after much hacking I was
unable to get it to populate correctly. Something is going wrong in the
DataTables paginated callback which I'm unfamiliar with
I'm not sure if this is what you mean, but I noticed that the Actions
column is empty. In the poll-specific lists it contains the links to the
Reboot|Stop / Start|Destroy actions.
Is it possible to add that to the patch? I'll ACK this if it's not
(better than what we have now) but it would be great to have the lists
behave the same.
Thomas
- I added the 'PermissionedObject' module to the instance
model,
which gives us a working Instance.list_by_user(current_user) method. The
problem is, is in the DataTable instance query conditions, I'm not sure
how to (or even if I can) make use of the list_by_user method (look for
the fixme in the patch)
- I didn't expand the Instance::COLUMNS field to include provider /
account as it is being used elsewhere and could cause breakage, though
the image column should now display the name correctly as that
functionality should already be working.
Most likely the current issues are small and can be resolved quickly on
IRC tonight/tommorow.
-Mo