mtaylor(a)redhat.com wrote:
This Series of patches adds the ability to Create/Edit/Delete quota
on Pools and Cloud Accounts. It Audits quota by storing totals on the quota model. Then
enforces the Quota on Instance Create/Start in TaskOMatic
_______________________________________________
deltacloud-devel mailing list
deltacloud-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/deltacloud-devel
I'm replying to the three patches now with some inline comments. I
haven't tested the patches yet (I'll do that hopefully later
today/tonight), but I thought I'd get these comments out.
Depending on time to fix, the comments could all be handled before
pushing _or_ as a follow-on patch a bit later. I'd suggest doing any
quick updates (such as the style fixes around calling Foo.find) before
pushing. More substantial bits such as any refactoring of
controllers/views and handling of null attributes can be handled later.
Also, one other thing, (again as a separate patch after this is pushed)
-- we need quota history as well. Since the quota objects now store both
usage limits and current usage, quota history may be simply a QuotaAudit
object type and a QuotaObserver -- so that any time the quota changes
(either by changing the quota limits, or any time an instance changes
state), we get an audit record showing what time period the given usage
for a pool/account was active. We need to be careful to avoid "off by
one" errors here, as the audit object is created at the _end_ of a
period of time with a given resource usage, so the beginning of the
period would be found by looking at the _end_ of the most recent audit
object on the given quota.
One other thing we'll need to do to enable auditing -- we may need to
simply allow quotas with all null maximum_ values -- where a null max
value means no limit. Then we automatically create empty quota objects
on pool/account creation. Otherwise we won't be tracking resource usage
over time for pools/accounts with no defined quota limits.
Anyway once I test the patches I'll send any further comments/acks/etc.
Scott