Tomas Sedovic wrote:
Hi Scott,
The patch works fine.
However, I noticed some code about enum entries that is commented out. Uncommenting it
seems to break the tests but that is not obvious from the code.
Could you please either delete these parts or add an explanation to them about why they
are commented out and what to do to make it work again?
Other than that, ACK.
Thomas
Hi Tomas,
Thanks for catching that. This is some validation that I decided to
remove after some discussion on IRC -- we were hitting some circular
dependencies in the validations and decided that it wasn't absolutely
needed after all.
I removed the commented-out code and pushed.
Scott