On Fri, 2011-07-08 at 13:06 -0700, Ian Main wrote:
So Michal and I have been working on a Condor based cloud using deltacloud as the front end API. The code base can be found here:
Very cool.
I completely agree that this should be merged into deltacloud proper. Some notes from looking at the code:
* Remove 'Copyright ...' from all source files (have a look at the other drives for proper headers) * There's some trailing whitespace trouble * condor_driver.rb:58: Don't set CONDOR_MAPPER_DIR to something that's relative to File::dirname(__FILE__) - instead write to /var/tmp (we really ought to claim /var/lib/deltacloud for things like this) * condor_driver.rb (create_instance): I find encoding config_server IP and uuid very ugly. Could the config_server IP become part of the config of condor-cloud ? Could we use the API_PROVIDER for this ? The uuid could be passed in as the user_name of the instance. The comment explaining what's happening with user_data also doesn't match the code * condor_driver.rb (valid_credentials?): something a little less hardcoded would be nice ;) * condor_driver.rb (remove_key): do we really want to ignore _all_ exceptions and just log a warning ? If that is really intended, it deserves a comment * client/base_models.rb: I assume this will be removed, and the code will use the standard models from lib/deltacloud/models/ * there don't seem to be any tests for the actual driver - we will need to figure out a plan for adding them
David