Author: tmckay
Date: 2011-07-21 19:42:21 +0000 (Thu, 21 Jul 2011)
New Revision: 4880
Modified:
trunk/cumin/python/cumin/grid/job.py
Log:
Don't allow expressions to be double-quoted on edit by a user.
BZ723848
Modified: trunk/cumin/python/cumin/grid/job.py
===================================================================
--- trunk/cumin/python/cumin/grid/job.py 2011-07-21 19:30:36 UTC (rev 4879)
+++ trunk/cumin/python/cumin/grid/job.py 2011-07-21 19:42:21 UTC (rev 4880)
@@ -784,6 +784,11 @@
fval = "\"%s\"" % strip_string_quotes(fval)
orig = "\"%s\"" % strip_string_quotes(orig)
+ elif ftype == "expression":
+ # Might as well prevent user from inadvertently changing
+ # an expression into a string by adding double quotes
+ fval = strip_string_quotes(fval)
+
if fval != orig:
just_ads[unicode(field)] = fval
Show replies by date