This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash.
Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash.
Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text).
Run-tested (GUI and CLI).
Please review.
(Compressed to get under ml size limit)
It was extremely juice reading. Patch looks good. Patch does not set InformAll in databes. Denys will do that.
Reviewed by: npajkovs
On 03/03/2010 01:56 PM, Denys Vlasenko wrote:
This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash.
Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash.
Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text).
Run-tested (GUI and CLI).
Please review.
On Wed, 2010-03-03 at 13:56 +0100, Denys Vlasenko wrote:
This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash.
Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash.
Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text).
Run-tested (GUI and CLI).
This version fixes an omission in v2: COL_INFORMALL was never set to 1.
Please review.
(Compressed to get under ml size limit)
Look good.
Reviewed by: Nikola Pajkovsky npajkovs@redhat.com
On 03/04/2010 02:54 PM, Denys Vlasenko wrote:
On Wed, 2010-03-03 at 13:56 +0100, Denys Vlasenko wrote:
This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash.
Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash.
Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text).
Run-tested (GUI and CLI).
This version fixes an omission in v2: COL_INFORMALL was never set to 1.
Please review.
crash-catcher@lists.fedorahosted.org