Denys Vlasenko <dvlasenk(a)redhat.com> writes:
On Tue, 2011-03-29 at 16:27 +0200, Nikola Pajkovsky wrote:
> solution isn't good enough, but truly remove misleading message. Imagine
> the situation when user manually set environment Bugzilla_Password and manually
> run command a-a-b -c /path/to/config1 -c /path/config2 -c /path/config3.
> Now a-a-b smash all configs into one giant hash table. Just stir the pot.
> Environment can be set by cli and gui. We have a lot of input how to set
> config and question is how to determinate which config is wrong and blame
> someone/something.
>
> Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com>
> ---
> src/plugins/abrt-action-bugzilla.cpp | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/src/plugins/abrt-action-bugzilla.cpp
b/src/plugins/abrt-action-bugzilla.cpp
> index e5e5bc8..e066142 100644
> --- a/src/plugins/abrt-action-bugzilla.cpp
> +++ b/src/plugins/abrt-action-bugzilla.cpp
> @@ -643,9 +643,7 @@ static void report_to_bugzilla(
> env = getenv("Bugzilla_Password");
> password = env ? env : get_map_string_item_or_empty(settings,
"Password");
> if (!login[0] || !password[0])
> - {
> - error_msg_and_die(_("Empty login or password, please check %s"),
PLUGINS_CONF_DIR"/Bugzilla.conf");
> - }
> + error_msg_and_die(_("Empty login or password, please check your
configuration"));
>
> env = getenv("Bugzilla_BugzillaURL");
> bugzilla_url = env ? env : get_map_string_item_or_empty(settings,
"BugzillaURL");
Looks good, please apply.
thanks, merge with master branch
--
Nikola