On 10/02/2012 02:57 PM, Denys Vlasenko wrote:
Hi Marko,
In my opinion tests/runtests/dumpoops/examples.tar
file, which you added, should not exist. Reasons:
(1) It duplicates eaxmples/* files. Now anyone
adding/modifying an example oops file needs
to add/modify it in two places. This will inevitably
fall out of sync.
(2) tarball is a wrong format to store data
in a versioned data store (git). It's a binary file,
and change to any part of it isn't handled well
by git when user wants to see the history -
git just says that this binary file was changed.
Hi,
no problem, we just need to rewrite the test to use files from examples/
directory.
--
Richard Marko