On Mon, 2010-06-07 at 16:26 +0200, Jiri Moskovcak wrote:
Sending a new version, with many fixes.
Please review,
Jirka
On 06/07/2010 11:51 AM, Denys Vlasenko wrote:
> On Thu, 2010-06-03 at 20:06 +0200, Jiri Moskovcak wrote:
>> This patch should fix the text wrapping and aligning. Doesn't implement
>> the dynamic text re-wrapping when the window is resized.
>>
>> Please review,
>
> Tried it applied over current git.
> No more huge oversized windows, and bad justification problem is gone.
>
> One problem remains: if I select two reporters, only last reporter's
> status is displayed. See attached image: it only shows Logger's result,
> no Bugzilla result is shown.
>
- fixed
> Also:
> (1) "Finish sending the report" -> perhaps "Finished sending the
> report"?
- fixed
> (2) "Thank you for your bug report. It has been succesfully submitted.
> You may view your bug report online using the web adress below:"
> doesn't look too good.
> (a) two typos: succesfully -> successfully, adress -> address
- fixed
> (b) it scrolls past window end (see attached)
> (c) how do we know the result has useful URL?
> For one, kerneloops 100% does not. We lie to user here.
> With RH support plugins, it also looks ugly.
> Maybe just use "Bug has been reported successfully:" and that's it?
- text changed
I see, but it still doesn't fit in the window for me. See attached.
Feel free to shorten it even more... Hmmm.... Actually,
"Finished sending the bug report" already says everything
we want to tell the user here, so you may as well remove
the whole text.
Apart from this, looks really good.
Wow, it even has another buglet fixed which I forgot to mention
("too wide window for no apparent reason" thing)!
--
vda