CCing crash-catcher(a)lists.fedorahosted.org
-------- Původní zpráva --------
Předmět: Re: [Crash-catcher] [PATCH] Check conf file for syntax errors
Datum: Wed, 16 Jun 2010 12:34:18 +0200
Od: Karel Klic <kklic(a)redhat.com>
Komu: Jiri Moskovcak <jmoskovc(a)redhat.com>
Dne 16.6.2010 11:42, Jiri Moskovcak napsal(a):
I did a quick test and the patch seems to work (doesn't break
anything
:)) but I found some cases when it should definitely complain:
1. the section is not closed:
[ AnalyzerAndReporters
Yes, I'll fix it.
2. the value is missing:
OpenGPGCheck =
- but it complains on:
OpenGPGCheck
This is intentional. The empty value should be allowed in parser.
The other think is that OpenGPGCheck's value should be only yes or no.
We should limit the values of various settings. However, let's do it
another day, as it is more than a few lines to do it for all
configuration entries and we will rewrite Settings.h/cpp to C (GLib?)
anyhow.
You can push the patch to git and take my notes as a TODO :))
Jirka
reviewed by: jmoskovc(a)redhat.com
Thank you.
K