Compiles and works ok and I don't see any major problems at first sight, just a few minor ones:
- remove the trailing spaces before you push it into git - not sure about removing the (now commented out) code for writing the settings in $HOME, as the plan is to split the daemon into root/non-root parts (but we can always find it in git history :)
Reviewed by: jmoskovc@redhat.com
On 03/15/2010 05:25 PM, Karel Klic wrote:
Hi,
The attached patch allows user to select which reporter he wants to use to report a crash using CLI. The daemon skips reporters which are not in the list of reporters provided via Report() dbus call.
src/CLI/dbus.cpp
- added GetSettings dbus call
- send reporters list when calling dbus Report()
src/CLI/report.cpp
- new functions split()
- new function get_enabled_reporters(crash_report)
- new function ask_yesno(question)
- get_reporter_plugin_settings now gets the list of reporters
- report using all reporters only in the --report-always mode
- ask if user wants to report using a particular reporter;
if he agrees, then check the reporter configuration (and ask for login/password if it's missing) src/Daemon/CommLayerServerDBus.cpp
- pass reporter list from Report() dbus call to Report()
implementation in MiddleWare.cpp src/Daemon/MiddleWare.cpp
- skip reporters which are not in the list in Report()
- removed old commented ~/.abrt code which is now in CLI
Best regards, Karel
Crash-catcher mailing list Crash-catcher@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/crash-catcher