== src/daemon/PluginManager.cpp, method CPluginManager::LoadPlugin
if (enabled_only) { if (!string_to_bool(get_map_string_item_or_empty(pluginSettings, "Enabled"))) { plugin_info["Enabled"] = "no"; string empty; plugin_info["Type"] = empty; ... VERB3 log("Plugin %s: 'Enabled' is not set, not loading it (yet)", pName);
@@@@@@@@@@@@ MISSING HERE?: free_map_string(pluginSettings);
return NULL; /* error */ } }
This method CPluginManager::LoadPlugin also works a lot with local plugin_info structure, which seems to be never used. I guess the whole CPluginSettings will be removed soon. Or should we remove that dead code?
== src/cli/report.cpp, function get_reporter_plugin_settings():
char *key; map_string_t *value;
I think 'key' should be renamed to 'plugin_name', and 'value' to 'plugin_settings'. Then
char *key2; char *value2;
could be renamed to 'key' and 'value'. Those are correct names here, because the variables represent a key=value pair in a settings file.
K