On Mon, 2010-10-04 at 12:05 +0200, Nikola Pajkovsky wrote:
vector_string_t was replaced by glist in these files
Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com>
if (cnt > 0) {
if (opt_s) {
int i = 0;
- while (i < oopsList.size()) {
- printf("\nVersion: %s", oopsList[i].c_str());
+ int length = g_list_length(oopsList);
+ // why while and not for?
+ while (i < length) {
+ printf("\nVersion: %s", (char*)g_list_nth_data(oopsList, i));
i++;
}
}
Indentation is a bit off.
The "// why while and not for?" comment
is not really needed: here, both while() and for() loops can be used.
Whoever wrote the code used while(). Since we don't have any
style preferences either way, it's not a crime...
- /*dlclose(handle); - why bother? */
+ for (GList *li = oopsList; li != NULL; li = g_list_next(li))
+ free((char*)li->data);
+
+ g_list_free(oopsList);
+ /*dlclose(handle); - why bother?
+ * cos we are handsome and good lookin' guys :D
+ */
Indentation is a bit off.
Apart from these, patch looks ok. Please apply.
--
vda