[PATCH v3] cleanup mess in .gitignore
by Nikola Pajkovsky
Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com>
---
.gitignore | 100 ++++++++++++++++++++++++++++++++++++++++-------------------
1 files changed, 68 insertions(+), 32 deletions(-)
diff --git a/.gitignore b/.gitignore
index d933495..137fa1a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,16 +1,55 @@
-\#*
-cscope.out
+# NOTE! Please use 'git ls-files -i --exclude-standard'
+# command after changing this file, to see if there are
+# any tracked files which get ignored after the change.
+
+# normal rules
*.o
*.lo
*.la
-abrt-*.rpm
-abrt-?.?.*.tar.gz
-abrt-?.?.*/
-i686/
-po/*.gmo
+
+# ignore binaries
+src/plugins/abrt-action-analyze-c
+src/plugins/abrt-action-analyze-oops
+src/plugins/abrt-action-bugzilla
+src/plugins/abrt-action-rhtsupport
+src/plugins/abrt-action-kerneloops
+src/plugins/abrt-action-analyze-python
+src/plugins/abrt-action-generate-backtrace
+src/plugins/abrt-action-upload
+src/plugins/abrt-action-mailx
+src/plugins/abrt-action-print
+src/plugins/abrt-dump-oops
+
+src/daemon/abrt-action-save-package-data
+src/daemon/abrt-handle-crashdump
+src/daemon/abrt-server
+src/daemon/abrtd
+
+src/gui-gtk/abrt-gtk
+
+src/applet/abrt-applet
+
+src/cli/abrt-cli
+
+src/hooks/abrt_exception_handler.py
+src/hooks/abrt-hook-ccpp
+
+src/applet/abrt-applet.desktop
+src/gui/abrt.desktop
+
+# cscope files
+cscope.*
+ncscope.*
+
+# gnu global files
+GPATH
+GRTAGS
+GSYMS
+GTAGS
+
+# autotools
.deps
.libs
-*~
Makefile
Makefile.in
m4
@@ -31,7 +70,12 @@ depcomp
install-sh
libtool
ltmain.sh
-ylwrap
+py-compile
+stamp-h1
+tests/atconfig
+tests/atlocal
+
+# po files
po/Makevars.template
po/notexist
po/POTFILES
@@ -46,27 +90,19 @@ po/remove-potcdate.sed
po/remove-potcdate.sin
po/stamp-po
po/stamp-it
-py-compile
-src/applet/abrt-applet
-src/applet/abrt-applet.desktop
-src/cli/abrt-cli
-src/daemon/abrtd
-src/gui/abrt.desktop
-src/hooks/abrt_exception_handler.py
-src/hooks/abrt-hook-ccpp
-stamp-h1
-x86_64/
+po/*.gmo
+
+# compiled python files
*.pyc
-src/daemon/abrt-action-save-package-data
-src/daemon/abrt-handle-crashdump
-src/daemon/abrt-server
-src/plugins/abrt-action-analyze-c
-src/plugins/abrt-action-analyze-oops
-src/plugins/abrt-action-bugzilla
-src/plugins/abrt-action-rhtsupport
-src/plugins/abrt-action-kerneloops
-src/plugins/abrt-action-analyze-python
-src/plugins/abrt-action-generate-backtrace
-src/plugins/abrt-action-upload
-src/plugins/abrt-action-mailx
-src/plugins/abrt-action-print
+
+# misc
+\#*
+*~
+
+# if you want to enable them, be aware of that 'git clean -df' won't clean them
+# and you have to do it *manually*
+# x86_64/
+# abrt-*.rpm
+# abrt-?.?.*.tar.gz
+# abrt-?.?.*/
+# i686/
--
1.7.1
13 years, 3 months
[PATCH v2] cleanup mess in .gitignore
by Nikola Pajkovsky
Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com>
---
.gitignore | 99 ++++++++++++++++++++++++++++++++++++++++-------------------
1 files changed, 67 insertions(+), 32 deletions(-)
diff --git a/.gitignore b/.gitignore
index d933495..5d3fbb1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,16 +1,55 @@
-\#*
-cscope.out
+# NOTE! Please use 'git ls-files -i --exclude-standard'
+# command after changing this file, to see if there are
+# any tracked files which get ignored after the change.
+
+# normal rules
*.o
*.lo
*.la
-abrt-*.rpm
-abrt-?.?.*.tar.gz
-abrt-?.?.*/
-i686/
-po/*.gmo
+
+# ignore binaries
+src/plugins/abrt-action-analyze-c
+src/plugins/abrt-action-analyze-oops
+src/plugins/abrt-action-bugzilla
+src/plugins/abrt-action-rhtsupport
+src/plugins/abrt-action-kerneloops
+src/plugins/abrt-action-analyze-python
+src/plugins/abrt-action-generate-backtrace
+src/plugins/abrt-action-upload
+src/plugins/abrt-action-mailx
+src/plugins/abrt-action-print
+src/plugins/abrt-dump-oops
+
+src/daemon/abrt-action-save-package-data
+src/daemon/abrt-handle-crashdump
+src/daemon/abrt-server
+src/daemon/abrtd
+
+src/gui-gtk/abrt-gtk
+
+src/applet/abrt-applet
+
+src/cli/abrt-cli
+
+src/hooks/abrt_exception_handler.py
+src/hooks/abrt-hook-ccpp
+
+src/applet/abrt-applet.desktop
+src/gui/abrt.desktop
+
+# cscope files
+cscope.*
+ncscope.*
+
+# gnu global files
+GPATH
+GRTAGS
+GSYMS
+GTAGS
+
+# autotools
.deps
.libs
-*~
Makefile
Makefile.in
m4
@@ -31,7 +70,11 @@ depcomp
install-sh
libtool
ltmain.sh
-ylwrap
+py-compile
+stamp-h1
+tests/*
+
+# po files
po/Makevars.template
po/notexist
po/POTFILES
@@ -46,27 +89,19 @@ po/remove-potcdate.sed
po/remove-potcdate.sin
po/stamp-po
po/stamp-it
-py-compile
-src/applet/abrt-applet
-src/applet/abrt-applet.desktop
-src/cli/abrt-cli
-src/daemon/abrtd
-src/gui/abrt.desktop
-src/hooks/abrt_exception_handler.py
-src/hooks/abrt-hook-ccpp
-stamp-h1
-x86_64/
+po/*.gmo
+
+# compiled python files
*.pyc
-src/daemon/abrt-action-save-package-data
-src/daemon/abrt-handle-crashdump
-src/daemon/abrt-server
-src/plugins/abrt-action-analyze-c
-src/plugins/abrt-action-analyze-oops
-src/plugins/abrt-action-bugzilla
-src/plugins/abrt-action-rhtsupport
-src/plugins/abrt-action-kerneloops
-src/plugins/abrt-action-analyze-python
-src/plugins/abrt-action-generate-backtrace
-src/plugins/abrt-action-upload
-src/plugins/abrt-action-mailx
-src/plugins/abrt-action-print
+
+# misc
+\#*
+*~
+
+# if you want to enable them, be aware that 'git clean -df' won't clean them
+# and you have to do it *manually*
+# x86_64/
+# abrt-*.rpm
+# abrt-?.?.*.tar.gz
+# abrt-?.?.*/
+# i686/
--
1.7.1
13 years, 3 months
[PATCH] cleanup mess in .gitignore
by Nikola Pajkovsky
Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com>
---
.gitignore | 102 ++++++++++++++++++++++++++++++++++++++++--------------------
1 files changed, 68 insertions(+), 34 deletions(-)
diff --git a/.gitignore b/.gitignore
index d933495..0dc6770 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,16 +1,55 @@
-\#*
-cscope.out
+# NOTE! Please use 'git ls-files -i --exclude-standard'
+# command after changing this file, to see if there are
+# any tracked files which get ignored after the change.
+
+# normal rules
*.o
*.lo
*.la
-abrt-*.rpm
-abrt-?.?.*.tar.gz
-abrt-?.?.*/
-i686/
-po/*.gmo
-.deps
-.libs
-*~
+
+# ignore binaries
+src/plugins/abrt-action-analyze-c
+src/plugins/abrt-action-analyze-oops
+src/plugins/abrt-action-bugzilla
+src/plugins/abrt-action-rhtsupport
+src/plugins/abrt-action-kerneloops
+src/plugins/abrt-action-analyze-python
+src/plugins/abrt-action-generate-backtrace
+src/plugins/abrt-action-upload
+src/plugins/abrt-action-mailx
+src/plugins/abrt-action-print
+src/plugins/abrt-dump-oops
+
+src/daemon/abrt-action-save-package-data
+src/daemon/abrt-handle-crashdump
+src/daemon/abrt-serve
+src/daemon/abrtd
+
+src/gui-gtk/abrt-gtk
+
+src/applet/abrt-applet
+
+src/cli/abrt-cli
+
+src/hooks/abrt_exception_handler.py
+src/hooks/abrt-hook-ccpp
+
+src/applet/abrt-applet.desktop
+src/gui/abrt.desktop
+
+# cscope files
+cscope.*
+ncscope.*
+
+# gnu global files
+GPATH
+GRTAGS
+GSYMS
+GTAGS
+
+# autotools
+*/.deps/
+*/.libs/
Makefile
Makefile.in
m4
@@ -31,7 +70,10 @@ depcomp
install-sh
libtool
ltmain.sh
-ylwrap
+py-compile
+stamp-h1
+
+# po files
po/Makevars.template
po/notexist
po/POTFILES
@@ -46,27 +88,19 @@ po/remove-potcdate.sed
po/remove-potcdate.sin
po/stamp-po
po/stamp-it
-py-compile
-src/applet/abrt-applet
-src/applet/abrt-applet.desktop
-src/cli/abrt-cli
-src/daemon/abrtd
-src/gui/abrt.desktop
-src/hooks/abrt_exception_handler.py
-src/hooks/abrt-hook-ccpp
-stamp-h1
-x86_64/
+po/*.gmo
+
+# compiled python files
*.pyc
-src/daemon/abrt-action-save-package-data
-src/daemon/abrt-handle-crashdump
-src/daemon/abrt-server
-src/plugins/abrt-action-analyze-c
-src/plugins/abrt-action-analyze-oops
-src/plugins/abrt-action-bugzilla
-src/plugins/abrt-action-rhtsupport
-src/plugins/abrt-action-kerneloops
-src/plugins/abrt-action-analyze-python
-src/plugins/abrt-action-generate-backtrace
-src/plugins/abrt-action-upload
-src/plugins/abrt-action-mailx
-src/plugins/abrt-action-print
+
+# misc
+\#*
+*~
+
+# if you want to enable them, be aware that 'git clean -df' won't clean them
+# and you have to do it *manually*
+# x86_64/
+# abrt-*.rpm
+# abrt-?.?.*.tar.gz
+# abrt-?.?.*/
+# i686/
--
1.7.1
13 years, 3 months
attachments
by Nikola Pajkovsky
Here is how files are marked now. Full flags looks like
TXT|BIN|SYS|(MULTILINE || ONELINE).
ONELINE/MULTILINE is for testing purpose hardcoded, but I'm going to
introduce a new flag CD_FLAG_ONELINE.
Odd situation begins when file is a small, text and and not from abrt
...
unknown file 'secure' flags TXT|BIN||NOTEDITABLE|MULTILINE
...
solution is not mark unknown file as CD_FLAG_BIN, but mark it as
CD_FLAG_UNKNOWN (also I will introduce a new flag).
also is_text_file() return NULL even file is text based and is huge, so
huge files are marked as binary file which is a little bit confusing
(big backtrace will be marked as a BIN file).
Decide what is or not attachment:
UNKNOWN | !ONELINE -> attach
UNKNOWN | TXT | ONELINE-> inline into report
SYS | TXT -> inline into report (basically its analyzer, kernel,
rating, ...)
BIN -> attach
What do you think?
known file 'kernel' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'anaconda.storage.log' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'anaconda.program.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
known file 'analyzer' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'coredump' flags |BIN|SYS|NOTEDITABLE|MULTILINE
unknown file 'mcelog' flags TXT|BIN||NOTEDITABLE|ONELINE
known file 'rating' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'uid' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'wtmp' flags |BIN||NOTEDITABLE|MULTILINE
known file 'hostname' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'boot.log-20101205' flags |BIN||NOTEDITABLE|MULTILINE
known file 'crash_function' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'reproduce' flags TXT||SYS|EDITABLE|MULTILINE
known file 'global_uuid' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'executable' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'package' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'maillog' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'wpa_supplicant.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
known file 'component' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'bashrc' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'boot.log' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'cron' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'btmp' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'spooler-20101205' flags TXT|BIN||NOTEDITABLE|ONELINE
unknown file 'cron-20101205' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'secure' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'lastlog' flags |BIN||NOTEDITABLE|ONELINE
known file 'cmdline' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'time' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'dmesg.old' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'messages' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'Xorg.0.log' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'anaconda.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'pm-powersave.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'yum.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
known file 'architecture' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'reason' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'uuid' flags TXT||SYS|NOTEDITABLE|ONELINE
known file 'count' flags TXT||SYS|NOTEDITABLE|MULTILINE
known file 'description' flags TXT||SYS|EDITABLE|MULTILINE
known file 'message' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'Xorg.9.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'Xorg.0.log.old' flags |BIN||NOTEDITABLE|MULTILINE
unknown file 'tallylog' flags TXT|BIN||NOTEDITABLE|ONELINE
known file 'backtrace' flags TXT||SYS|EDITABLE|MULTILINE
unknown file 'messages-20101205' flags |BIN||NOTEDITABLE|MULTILINE
known file 'release' flags TXT||SYS|NOTEDITABLE|ONELINE
unknown file 'maillog-20101205' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'spooler' flags TXT|BIN||NOTEDITABLE|ONELINE
unknown file 'secure-20101205' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'pm-suspend.log' flags TXT|BIN||NOTEDITABLE|MULTILINE
unknown file 'dmesg' flags |BIN||NOTEDITABLE|MULTILIN
<snip from code>
char *short_name;
char *full_name;
dd_init_next_file(dd);
while (dd_get_next_file(dd, &short_name, &full_name))
{
int flags = 0;
ssize_t sz = 4*1024;
char *text = is_text_file(full_name, &sz);
flags |= (text) ? CD_FLAG_TXT : CD_FLAG_BIN;
if (is_editable_file(short_name))
flags |= CD_FLAG_ISEDITABLE;
else
flags |= CD_FLAG_ISNOTEDITABLE;
const char *const *v = abrt_known_files;
while (*v)
{
if (strcmp(*v, short_name) == 0)
break;
v++;
}
/* known by abrt is CD_FLAG_SYS
* unknown by abrt is CD_FLAG_BIN */
flags |= (*v) ? CD_FLAG_SYS : CD_FLAG_BIN;
char *content;
if (text && sz < 4*1024) /* is_text_file did read entire file */
content = xstrndup(text, sz); //TODO: can avoid this
copying if is_text_file() adds NUL
else /* no, need to read it all */
content = dd_load_text(dd, short_name);
free(text);
int multiline = strchr(content, '\n') != NULL;
char *flags_str = xasprintf("flags %s|%s|%s|%s|%s",
(flags & CD_FLAG_TXT) ? "TXT": "",
(flags & CD_FLAG_BIN) ? "BIN": "",
(flags & CD_FLAG_SYS) ? "SYS": "",
(flags & CD_FLAG_ISEDITABLE) ?
"EDITABLE": "NOTEDITABLE",
(multiline) ? "MULTILINE": "ONELINE");
if (*v)
log("known file '%s' %s", *v, flags_str);
else
log("unknown file '%s' %s", short_name, flags_str);
</snip>
--
Nikola
13 years, 3 months
abrt-cli conversion to local processing
by Denys Vlasenko
Hi,
After a quick look at abrt-cli source, I think this can be approached
like this:
We add -D DIR option which specifies which directory to list.
It can be used more than once. If it is not specified,
abrt-cli defaults to -D /var/spool/abrt -D $HOME/abrt/spool.
With "abrt-cli --list", dumps from all these directories
are shown.
When "abrt-cli --report DUMP_DIR" is run and abrt-cli detects
that it can't lock DUMP_DIR for writing, it informs the user:
DUMP_DIR is not writable.
Do you want to copy it to $HOME/abrt/spool? (y/n)
(The directory to copy to can be specified by another option,
-W DIR; or we can have a convention that the DIR from the
first -D DIR option is used)
When "abrt-cli --delete DUMP_DIR" is run and abrt-cli detects
that it can't lock DUMP_DIR for writing, it tries to delete
the directory through dbus call to abrtd.
I am proceeding with implementing it. But don't hesitate
to provide your comments on the above.
Maybe I miss some problem?
--
vda
13 years, 3 months
[PATCH 1/2] load_plugin_settings.c: remove unused variable
by Nikola Pajkovsky
Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com>
---
src/lib/load_plugin_settings.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/lib/load_plugin_settings.c b/src/lib/load_plugin_settings.c
index 0f38906..1e6b31e 100644
--- a/src/lib/load_plugin_settings.c
+++ b/src/lib/load_plugin_settings.c
@@ -35,7 +35,6 @@ bool load_conf_file(const char *pPath, map_string_h *settings, bool skipKeysWith
while ((line = xmalloc_fgetline(fp)) != NULL)
{
unsigned ii;
- bool is_value = false;
bool valid = false;
bool in_quote = false;
/* We are reusing line buffer to form temporary
@@ -61,7 +60,6 @@ bool load_conf_file(const char *pPath, map_string_h *settings, bool skipKeysWith
}
if (line[ii] == '=' && !in_quote)
{
- is_value = true;
valid = true;
*cur++ = '\0'; /* terminate key */
value = cur; /* remember where value starts */
--
1.7.4.rc2.3.g60a2e
13 years, 3 months