On 10/06/2011 11:31 AM, Martin Milata wrote:
This should be more informative than the dump dir we are displaying now (and which is still a fallback if there is no reason item).
- seems ok, please push it
src/gui-wizard-gtk/wizard.c | 15 +++++++++++++-- 1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c index 8bdc8d1..18826ab 100644 --- a/src/gui-wizard-gtk/wizard.c +++ b/src/gui-wizard-gtk/wizard.c @@ -326,6 +326,17 @@ static void show_event_opt_error_dialog(const char *event_name) gtk_widget_destroy(wrong_settings); }
+static void update_window_title(void) +{
- /* prgname can be null according to gtk documentation */
- const char *prgname = g_get_prgname();
- const char *reason = get_problem_item_content_or_NULL(g_cd, FILENAME_REASON);
- char *title = xasprintf("%s - %s", (reason ? reason : g_dump_dir_name),
(prgname ? prgname : "report"));
- gtk_window_set_title(GTK_WINDOW(g_assistant), title);
- free(title);
+}
- struct dump_dir *steal_if_needed(struct dump_dir *dd) { if (!dd)
@@ -375,7 +386,7 @@ struct dump_dir *steal_if_needed(struct dump_dir *dd) g_dump_dir_name = xstrdup(dd->dd_dirname); dd_close(dd);
- gtk_window_set_title(GTK_WINDOW(g_assistant), g_dump_dir_name);
- update_window_title(); delete_dump_dir_possibly_using_abrtd(old_name); //TODO: if (deletion_failed) error_msg("BAD")? free(old_name);
@@ -1029,7 +1040,7 @@ static void update_event_checkboxes(GList **events_gui_data,
void update_gui_state_from_problem_data(void) {
- gtk_window_set_title(GTK_WINDOW(g_assistant), g_dump_dir_name);
update_window_title();
const char *reason = get_problem_item_content_or_NULL(g_cd, FILENAME_REASON); const char *not_reportable = get_problem_item_content_or_NULL(g_cd,