On Wednesday, March 21, 2018 12:36:25 PM CET Miroslav Suchý wrote:
Dne 21.3.2018 v 12:28 Pavel Raiskup napsal(a):
4. store **only** the **app** credentials into copr
Yes. Only one app for all projects and all githubs and individual permission for each specific Github is granted via OAuth.
GitHub OAuth:
pros: users don't have to create custom app (a few clicks anyway) cons: that app has complete access to the repo, even push
GitHub App:
pros: users can grant the app to e.g. only set the "CI flags" in PR cons: users have to create the custom app in web-ui
To me, we should support both ways (oauth for convenience of users).. but I voted for non-OAuth as that's the only option I would _personaly_ accept.
Pavel