[copr] master: W: 5, 0: Unused import fcntl (unused-import) (1c77870)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 1c778708df8cdac0c87acd10ff32c7f54b1977b4
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:31:05 2015 +0100
W: 5, 0: Unused import fcntl (unused-import)
>---------------------------------------------------------------
backend/backend/helpers.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/backend/backend/helpers.py b/backend/backend/helpers.py
index 695e885..0c11146 100644
--- a/backend/backend/helpers.py
+++ b/backend/backend/helpers.py
@@ -2,7 +2,6 @@ from __future__ import print_function
from __future__ import unicode_literals
from __future__ import division
from __future__ import absolute_import
-import fcntl
import json
import logging
import logging.handlers
8 years, 6 months
[copr] master: create copr-backend-service script to handle all copr services (7b3ab90)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 7b3ab905954f3f041fdbffa5eb459abb4d51ba75
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:24:24 2015 +0100
create copr-backend-service script to handle all copr services
>---------------------------------------------------------------
backend/copr-backend-service | 101 ++++++++++++++++++++++++++++++++++++++++++
backend/copr-backend.spec | 2 +
2 files changed, 103 insertions(+), 0 deletions(-)
diff --git a/backend/copr-backend-service b/backend/copr-backend-service
new file mode 100755
index 0000000..d0f80dd
--- /dev/null
+++ b/backend/copr-backend-service
@@ -0,0 +1,101 @@
+#!/bin/sh
+
+if [ $EUID -ne 0 ]; then
+ echo -e "This script must be run as root!\n"
+ exit 1
+fi
+
+
+
+copr_target_services() {
+ echo copr-backend copr-backend-vmm copr-backend-log copr-backend-jobgrab
+}
+
+turn_on() {
+ echo "Enabling Copr backend services..."
+ copr_target_services | xargs systemctl enable --quiet
+ echo "Done"
+ return 0
+}
+
+turn_off() {
+ echo "Disabling Copr backend services..."
+ copr_target_services | xargs systemctl disable --quiet
+ echo "Done"
+ return 0
+}
+
+list() {
+ echo "Listing Copr backend services..."
+ systemctl list-unit-files --type=service | grep -F "$(copr_target_services)"
+ echo "Done"
+ return 0
+}
+
+start() {
+ echo "Starting Copr backend services..."
+ systemctl start $(copr_target_services)
+ echo "Done."
+ return 0
+}
+
+stop() {
+ echo "Shutting down Copr backend services..."
+ copr_target_services | xargs systemctl stop
+ echo "Done."
+ return 0
+}
+
+status() {
+ copr_target_services | xargs systemctl status -n0
+ return $?
+}
+
+if [ $? != 0 ] ; then echo "Terminating..." >&2 ; exit 1 ; fi
+
+while true ; do
+ case "$1" in
+ --)
+ shift
+ break
+ ;;
+ start|stop|enable|disable|list|status|restart|reload)
+ break
+ ;;
+ *)
+ echo "Internal error [$1]!" >&2
+ exit 1
+ ;;
+ esac
+ shift
+done
+
+case "$1" in
+ start)
+ start
+ ;;
+ stop)
+ stop
+ ;;
+ enable)
+ turn_on
+ ;;
+ disable)
+ turn_off
+ ;;
+ list)
+ list
+ ;;
+ status)
+ status
+ ;;
+ restart|reload)
+ stop
+ start
+ ;;
+ *)
+ echo "Usage: $(basename $0) {start|stop|status|reload|restart|enable|disable}"
+ exit 1
+ ;;
+esac
+exit $?
diff --git a/backend/copr-backend.spec b/backend/copr-backend.spec
index 8abb276..af4ee0d 100644
--- a/backend/copr-backend.spec
+++ b/backend/copr-backend.spec
@@ -142,6 +142,7 @@ install -d %{buildroot}%{_sysconfdir}/cron.daily
install -d %{buildroot}%{_sysconfdir}/sudoers.d
install -d %{buildroot}%{_bindir}/
+cp -a copr-backend-service %{buildroot}/%{_sbindir}/
cp -a backend/* %{buildroot}%{_datadir}/copr/backend
cp -a run/* %{buildroot}%{_bindir}/
cp -a conf/copr-be.conf.example %{buildroot}%{_sysconfdir}/copr/copr-be.conf
@@ -228,6 +229,7 @@ useradd -r -g copr -G lighttpd -s /bin/bash -c "COPR user" copr
%{_unitdir}/*.service
%{_tmpfilesdir}/copr-backend.conf
%{_bindir}/*
+%{_sbindir}/*
%config(noreplace) %{_sysconfdir}/cron.daily/copr-backend
%{_datadir}/logstash/patterns/lighttpd.pattern
8 years, 6 months
[copr] master: W: 12, 0: Unused format_tb imported from backend.helpers (unused-import) (d27908b)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit d27908b5ab9cdb2e508091b492529efeccb89b6a
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:41:13 2015 +0100
W: 12, 0: Unused format_tb imported from backend.helpers (unused-import)
>---------------------------------------------------------------
backend/backend/vm_manage/check.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/vm_manage/check.py b/backend/backend/vm_manage/check.py
index 568e6a7..e139256 100644
--- a/backend/backend/vm_manage/check.py
+++ b/backend/backend/vm_manage/check.py
@@ -7,7 +7,7 @@ import time
from ansible.runner import Runner
-from backend.helpers import get_redis_connection, format_tb
+from backend.helpers import get_redis_connection
from backend.vm_manage import PUBSUB_MB, EventTopics
from backend.vm_manage.executor import Executor
8 years, 6 months
[copr] master: W: 81, 4: Redefining name 'os' from outer scope (line 12) (redefined-outer-name) (d3cd9ce)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit d3cd9ceb2b53c3c82ccb2d29395e1706e1052a51
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:27:23 2015 +0100
W: 81, 4: Redefining name 'os' from outer scope (line 12) (redefined-outer-name)
>---------------------------------------------------------------
backend/backend/helpers.py | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/backend/backend/helpers.py b/backend/backend/helpers.py
index b611fa4..98e166d 100644
--- a/backend/backend/helpers.py
+++ b/backend/backend/helpers.py
@@ -78,12 +78,12 @@ def chroot_to_branch(chroot):
"""
Get a git branch name from chroot. Follow the fedora naming standard.
"""
- os, version, arch = chroot.split("-")
- if os == "fedora":
- os = "f"
- elif os == "epel" and int(version) <= 6:
- os = "el"
- return "{}{}".format(os, version)
+ os_name, version, arch = chroot.split("-")
+ if os_name == "fedora":
+ os_name = "f"
+ elif os_name == "epel" and int(version) <= 6:
+ os_name = "el"
+ return "{}{}".format(os_name, version)
class BackendConfigReader(object):
def __init__(self, config_file=None, ext_opts=None):
8 years, 6 months
[copr] master: W: 18, 0: Unused import PUBSUB_INTERRUPT_BUILDER (unused-import) (fa461a3)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit fa461a3918174a8127aeb8396ce514f995ebc97e
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:42:14 2015 +0100
W: 18, 0: Unused import PUBSUB_INTERRUPT_BUILDER (unused-import)
>---------------------------------------------------------------
backend/backend/vm_manage/manager.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/vm_manage/manager.py b/backend/backend/vm_manage/manager.py
index 8787811..3416837 100644
--- a/backend/backend/vm_manage/manager.py
+++ b/backend/backend/vm_manage/manager.py
@@ -15,7 +15,7 @@ from backend.exceptions import VmError, NoVmAvailable, VmDescriptorNotFound
from backend.helpers import get_redis_connection
from .models import VmDescriptor
-from . import VmStates, KEY_VM_INSTANCE, KEY_VM_POOL, EventTopics, PUBSUB_MB, KEY_SERVER_INFO, PUBSUB_INTERRUPT_BUILDER, \
+from . import VmStates, KEY_VM_INSTANCE, KEY_VM_POOL, EventTopics, PUBSUB_MB, KEY_SERVER_INFO, \
KEY_VM_POOL_INFO
from ..helpers import get_redis_logger
8 years, 6 months
[copr] master: W: 5, 0: Unused import sys (unused-import) (2c51f0f)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 2c51f0f88c610380ee84bb3c3d1e1004c6776359
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:26:22 2015 +0100
W: 5, 0: Unused import sys (unused-import)
>---------------------------------------------------------------
backend/backend/ans_utils.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/backend/backend/ans_utils.py b/backend/backend/ans_utils.py
index 5cf48d3..8189e57 100644
--- a/backend/backend/ans_utils.py
+++ b/backend/backend/ans_utils.py
@@ -2,7 +2,6 @@
import json
import subprocess
from subprocess import CalledProcessError
-import sys
ansible_playbook_bin = "ansible-playbook"
8 years, 6 months
[copr] master: W: 6, 0: Unused Thread imported from threading (unused-import) (c471ad9)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit c471ad97870407918130ac8eb9db584737a241d3
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:40:21 2015 +0100
W: 6, 0: Unused Thread imported from threading (unused-import)
>---------------------------------------------------------------
backend/backend/vm_manage/check.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/vm_manage/check.py b/backend/backend/vm_manage/check.py
index f63c6c8..a5e763b 100644
--- a/backend/backend/vm_manage/check.py
+++ b/backend/backend/vm_manage/check.py
@@ -3,7 +3,7 @@ import json
#from setproctitle import setproctitle
import time
# from multiprocessing import Process
-from threading import Thread
+#from threading import Thread
import sys
8 years, 6 months
[copr] master: W: 4, 0: Unused setproctitle imported from setproctitle (unused-import) (8b6a23d)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 8b6a23d8f6812b88dfc3721192e13aeacab54713
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:39:45 2015 +0100
W: 4, 0: Unused setproctitle imported from setproctitle (unused-import)
>---------------------------------------------------------------
backend/backend/vm_manage/check.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/vm_manage/check.py b/backend/backend/vm_manage/check.py
index e5b08fa..f63c6c8 100644
--- a/backend/backend/vm_manage/check.py
+++ b/backend/backend/vm_manage/check.py
@@ -1,6 +1,6 @@
# coding: utf-8
import json
-from setproctitle import setproctitle
+#from setproctitle import setproctitle
import time
# from multiprocessing import Process
from threading import Thread
8 years, 6 months
[copr] master: W: 14, 0: Unused MockRemoteError imported from exceptions (unused-import) (8c123f2)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 8c123f26bb2609d45dc9944477e3e4273b514a53
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:38:46 2015 +0100
W: 14, 0: Unused MockRemoteError imported from exceptions (unused-import)
>---------------------------------------------------------------
backend/backend/helpers.py | 1 +
backend/backend/sign.py | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/backend/backend/helpers.py b/backend/backend/helpers.py
index 42ae03b..3e9c028 100644
--- a/backend/backend/helpers.py
+++ b/backend/backend/helpers.py
@@ -316,6 +316,7 @@ class RedisPublishHandler(logging.Handler):
msg["traceback"] = format_tb(error, tb)
self.rc.publish(constants.LOG_PUB_SUB, json.dumps(msg))
+ # pylint: disable=W0703
except Exception as error:
_, _, ex_tb = sys.exc_info()
sys.stderr.write("Failed to publish log record to redis, {}"
diff --git a/backend/backend/sign.py b/backend/backend/sign.py
index 4965c9c..a5cc998 100755
--- a/backend/backend/sign.py
+++ b/backend/backend/sign.py
@@ -12,8 +12,7 @@ import os
from requests import request
from .exceptions import CoprSignError, CoprSignNoKeyError, \
- CoprKeygenRequestError, \
- MockRemoteError
+ CoprKeygenRequestError
SIGN_BINARY = "/bin/sign"
8 years, 6 months
[copr] master: W:323, 16: Unused variable 'err_class' (unused-variable) (f2d89ff)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit f2d89ffc409e9bcb725e4e3b4f8df89f6d8fc376
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 6 14:30:00 2015 +0100
W:323,16: Unused variable 'err_class' (unused-variable)
>---------------------------------------------------------------
backend/backend/helpers.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/helpers.py b/backend/backend/helpers.py
index 98e166d..91dca98 100644
--- a/backend/backend/helpers.py
+++ b/backend/backend/helpers.py
@@ -320,7 +320,7 @@ class RedisPublishHandler(logging.Handler):
if msg.get("exc_info"):
# from celery.contrib import rdb; rdb.set_trace()
- err_class, error, tb = msg.pop("exc_info")
+ _, error, tb = msg.pop("exc_info")
msg["traceback"] = format_tb(error, tb)
self.rc.publish(constants.LOG_PUB_SUB, json.dumps(msg))
8 years, 6 months