https://bugzilla.redhat.com/show_bug.cgi?id=1464329
--- Comment #2 from Dan Callaghan <dcallagh(a)redhat.com> ---
(In reply to Ralph Bean from comment #1)
Some issues based on the guidelines:
https://fedoraproject.org/wiki/Container:Guidelines#Container_Guidelines
- The labels need to be first defined as ENV variables and then used in the
LABELS in a second line. The name needs to be prefixed with $FGC.
Hmm yeah when I looked at the guidelines that was optional, and since nothing
in the container itself would ever refer to those environment variables I
figured it wasn't necessary.
But you are right, it seems mandatory now :-)
https://fedoraproject.org/w/index.php?title=Container:Guidelines&diff...
I am still unclear as to *why*, but I haven't seen the container build service
in action yet so I'll just assume it is needed for that.
- The help file needs to be called README.md or help.1 (not
help.md).
- The help file needs to be copied into the container at build time.
Same here... I was reading the container guidelines in conjunction with a
thread on an internal mailing list where there was some conflicting advice
offered about this... I had thought that help.md would be magically transformed
into help.1 *and* copied into the container for me by the build service. But
you are right, the container guidelines don't support that assumption.
Can you fix those up and I can take another look?
Will do! Updated version to come shortly.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ir7pWDi4Xs&a=cc_unsubscribe