https://bugzilla.redhat.com/show_bug.cgi?id=1862054
Athos Ribeiro <athoscribeiro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #7 from Athos Ribeiro <athoscribeiro(a)gmail.com> ---
This looks good to me.
I'd rather have that expose section improved, i.e., what are you exposing, and
how to use it. The run label example is not referencing the exposed port at
all.
I think it is OK to ask users to set their config files to use a specific port
so they won't need to change the "run" example or rebuild the image locally
to
expose a different port.
I will trust you will improve docs as it fits for trojan users, given you
definitely know the package better than I do.
Approved.
--
You are receiving this mail because:
You are on the CC list for the bug.