All,
I recently uploaded the current debian package profile for 0.92 to my Ubuntu PPA. The upload for wily (Ubuntu 15.10) built correctly and is now published. I uploaded the same source package for vivid (Ubuntu 15.04) and it failed with the following test failures:
--- mock/ssh/1-output 2015-11-03 17:36:41.000000000 +0000
+++ - 2016-01-21 04:30:56.392228214 +0000 @@ -1,4 +1,4 @@ 2048 FINGERPRINT authorized_keys (RSA) ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDpAQgUA3efyrzjxijOvvEPT4wtIk2GGVW8/Lw6tFa98yNpwT9xOZZnnyzlFwiCwjeBCqo8I7xwIPZVaoTb9yEuygUQj0FRi7CQfo6l63rgz3dXWMg09PYQgF3MX2Vo2fgMtsQgaZaHNJ+Mqew8Toe9dIQKup0gPrOw6mtAltmWUfDpDO33eljQV/BnjvHd3zoWw+EyJRUZ213FzfXnVVCOdY9sbIOT86rl6MpoGyCa+9OY6cSpVeFkCUwNplaYwGC4wBY74d0ZGI9GnSDEj1mU4XOSEWXSMFUxNcMkrIukZaNYzDYDsbgJJMy+M/DLfyrxQXpMe6MQQ5jhYXBm5NfF -2048 FINGERPRINT Comment Here (RSA) +2048 FINGERPRINT authorized_keys (RSA) ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDpAQgUA3efyrzjxijOvvEPT4wtIk2GGVW8/Lw6tFa98yNpwT9xOZZnnyzlFwiCwjeBCqo8I7xwIPZVaoTb9yEuygUQj0FRi7CQfo6l63rgz3dXWMg09PYQgF3MX2Vo2fgMtsQgaZaHNJ+Mqew8Toe9dIQKup0gPrOw6mtAltmWUfDpDO33eljQV/BnjvHd3zoWw+EyJRUZ213FzfXnVVCOdY9sbIOT86rl6MpoGyCa+9OY6cSpVeFkCUwNplaYwGC4wBY74d0ZGI9GnSDEj1mU4XOSEWXSMFUxNcMkrIukZaNYzDYDsbgJJMy+M/DLfyrxQXpMe6MQQ5jhYXBm5NfF Comment Here FAIL: pkg/users/test-list-public-keys.sh 1 mock/ssh/1-input PASS: pkg/users/test-list-public-keys.sh 2 mock/ssh/2-input --- mock/ssh/3-output 2015-11-03 17:36:41.000000000 +0000 +++ - 2016-01-21 04:30:56.408036648 +0000 @@ -1,2 +1,2 @@ -2048 FINGERPRINT Comment Here (RSA) +2048 FINGERPRINT authorized_keys (RSA) ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDpAQgUA3efyrzjxijOvvEPT4wtIk2GGVW8/Lw6tFa98yNpwT9xOZZnnyzlFwiCwjeBCqo8I7xwIPZVaoTb9yEuygUQj0FRi7CQfo6l63rgz3dXWMg09PYQgF3MX2Vo2fgMtsQgaZaHNJ+Mqew8Toe9dIQKup0gPrOw6mtAltmWUfDpDO33eljQV/BnjvHd3zoWw+EyJRUZ213FzfXnVVCOdY9sbIOT86rl6MpoGyCa+9OY6cSpVeFkCUwNplaYwGC4wBY74d0ZGI9GnSDEj1mU4XOSEWXSMFUxNcMkrIukZaNYzDYDsbgJJMy+M/DLfyrxQXpMe6MQQ5jhYXBm5NfF Comment Here FAIL: pkg/users/test-list-public-keys.sh 3 mock/ssh/3-input PASS: pkg/users/test-list-public-keys.sh 4 mock/ssh/4-input
I'm not even sure I know what these test are doing, much less why they're failing. Anyone shed any light?
Thanks,Jared
Looks like the tests produce different output than are expected.
Perhaps some changes are necessary to the normalize() function in test-list-public-keys.sh file?
It looks like "ssh-keygen -l -f <authorized_keys_file>" produces different output on wily (expected output) vs vivid (unexpected output)...
[image: Inline image 1]
On Mon, Feb 1, 2016 at 9:49 AM, Stef Walter stefw@fedoraproject.org wrote:
Looks like the tests produce different output than are expected.
Perhaps some changes are necessary to the normalize() function in test-list-public-keys.sh file? _______________________________________________ cockpit-devel mailing list cockpit-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/cockpit-devel@lists.fedorahosted....
Exactly. Stef was referring to the normalize function here: https://github.com/cockpit-project/cockpit/blob/0a0250e8118c47ced529772758d4...
Parsing text output is always problematic and has been an issue in the past, hence the normalization function.
Maybe you can adjust it to work with the new output.
-Dominik
On 02/01/2016 09:32 PM, Jared Sutton wrote:
It looks like "ssh-keygen -l -f <authorized_keys_file>" produces different output on wily (expected output) vs vivid (unexpected output)...
Inline image 1
On Mon, Feb 1, 2016 at 9:49 AM, Stef Walter <stefw@fedoraproject.org mailto:stefw@fedoraproject.org> wrote:
Looks like the tests produce different output than are expected. Perhaps some changes are necessary to the normalize() function in test-list-public-keys.sh file? _______________________________________________ cockpit-devel mailing list cockpit-devel@lists.fedorahosted.org <mailto:cockpit-devel@lists.fedorahosted.org> https://lists.fedorahosted.org/admin/lists/cockpit-devel@lists.fedorahosted.org
cockpit-devel mailing list cockpit-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/cockpit-devel@lists.fedorahosted....
This problem is occurring because the test script was written on a system with OpenSSH 6.8 (or greater) installed. Notice the 2nd bullet point under "New Features" on the following page:
http://www.openssh.com/txt/release-6.8
Older versions of OpenSSH used a hexed MD5 hash for fingerprints while 6.8 and greater use a Base64-encoded SHA256 hash (with the hash algorithm prepended). Unfortunately, I don't think any amount of "normalizing" will fix this issue.
On Mon, Feb 1, 2016 at 3:36 PM, Dominik Perpeet dperpeet@redhat.com wrote:
Exactly. Stef was referring to the normalize function here: https://github.com/cockpit-project/cockpit/blob/0a0250e8118c47ced529772758d4...
Parsing text output is always problematic and has been an issue in the past, hence the normalization function.
Maybe you can adjust it to work with the new output.
-Dominik
On 02/01/2016 09:32 PM, Jared Sutton wrote:
It looks like "ssh-keygen -l -f <authorized_keys_file>" produces different output on wily (expected output) vs vivid (unexpected output)...
[image: Inline image 1]
On Mon, Feb 1, 2016 at 9:49 AM, Stef Walter stefw@fedoraproject.org wrote:
Looks like the tests produce different output than are expected.
Perhaps some changes are necessary to the normalize() function in test-list-public-keys.sh file? _______________________________________________ cockpit-devel mailing list cockpit-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/cockpit-devel@lists.fedorahosted....
cockpit-devel mailing listcockpit-devel@lists.fedorahosted.orghttps://lists.fedorahosted.org/admin/lists/cockpit-devel@lists.fedorahosted....
cockpit-devel mailing list cockpit-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/cockpit-devel@lists.fedorahosted....
cockpit-devel@lists.fedorahosted.org