On Thu, May 24, 2018 at 9:22 AM, Martin Pitt <martin(a)piware.de> wrote:
Marius Vollmer [2018-05-24 9:52 +0300]:
> Can't this be decided by each page / package individually? Some of the
> Cockpit pages use jQuery, some use Mustache, most new ones use
It's really awkward to do this, as you would need per-page webpack
aliasing. I've done it a while ago for welder-web , and it's not pretty
breaks building with plain "webpack" (only works with "make").
> But patternfly-react certainly sounds like something that we should
Agreed, and possibly even get rid of some of our custom components.
> (Also, I remember there was some drama regarding the React license, has
> that been resolved?)
I don't remember that, but recently it's MIT:
That would interest me as well - aside from react-lite being smaller,
any other downsides?
I can imagine issues around prop-types, since they were "just written"
far, without their actual use. But this is nothing difficult to solve.
The react-lite claims to be replacement for React 15.x . Multiple 3rd party
dependencies within Cockpit expect React already and they build/behave
nicely so far. So I would extrapolate to Cockpit as expect same behavior.
React 16 as backward compatible with 15.
Anyway, manual testing will be required after the change.
cockpit-devel mailing list -- cockpit-devel(a)lists.fedorahosted.org
To unsubscribe send an email to cockpit-devel-leave(a)lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/cockpit-
senior software engineer
Red Hat Czech