Sanne replied to me directly and after cleaning my repo with git clean
it works fine now, I will go ahead and make updates to our repository
as you mentioned.
On Fri, Sep 27, 2019 at 9:31 AM Martin Pitt <mpitt(a)redhat.com> wrote:
Justin Stephenson [2019-09-24 10:30 -0400]:
> The session recording cockpit module is a bit behind the
> cockpit-starter-kit master, so I just cherry-picked the 'Update bots
> target for moved GitHub project' commit.
> Afterwards, 'make bots' works fine but I see this error when
> bots/image-customize is run from our makefile:
> I compared it to the cockpit-starter-kit master Makefile, and it has
> the same provided argument switches as far as I can tell.
I tried to reproduce this:
git clone https://github.com/Scribery/cockpit-session-recording.git
TEST_OS=fedora-30 make check
and that works fine -- well, I do get some test failures, but at least the
image-customize call was going through.
The most obvious explanation is that `pwd`/cockpit-session-recording-*.noarch.rpm
resolves to three instead of one rpm -- so that image-customize would be called
with an extra argument. I can replicate the error after
Does it work for you if you `rm *.rpm`?
The Makefile should be fixed to include the $(VERSION). I did that in
, after that lands you
should cherry-pick it into your project.
BTW, "rhel-x" hasn't been a thing for a long time, you probably want to
the default to TEST_OS=rhel-8-1 or perhaps fedora-30.
Thanks for the report!
cockpit-devel mailing list -- cockpit-devel(a)lists.fedorahosted.org
To unsubscribe send an email to cockpit-devel-leave(a)lists.fedorahosted.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines