Hi Cobbler Users:

When running cobbler import command the expectation should that it would fail when the json file has a syntax error, but is successfully completes.

There is lack of error checking even when issuing the command, but again import is completed successfully.

[root@ca-cobbler-admin links]# cobbler import --name=OVS-3.4.2-1384-x86_64 --arch=x86_64 --path=mnt
task started: 2016-09-26_162146_import
task started (id=Media import, time=Mon Sep 26 16:21:46 2016)
Found a candidate signature: breed=ovs, version=3.4.1
Found a matching signature: breed=ovs, version=3.4.1
Adding distros from path /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64:
creating new distro: OVS-3.4.2-1384-x86_64
trying symlink: /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64 -> /var/www/cobbler/links/OVS-3.4.2-1384-x86_64
creating new profile: OVS-3.4.2-1384-x86_64
associating repos
checking for uln repo(s)
skipping unknown/unsupported repo breed: uln
checking for yum repo(s)
starting descent into /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64 for OVS-3.4.2-1384-x86_64
processing repo at : /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64
need to process repo/comps: /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64
looking for /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/repodata/*comps*.xml
Keeping repodata as-is :/var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/repodata
processing repo at : /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/Transition
directory /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/Transition is missing xml comps file, skipping
processing repo at : /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/Server
need to process repo/comps: /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/Server
looking for /var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/Server/repodata/*comps*.xml
Keeping repodata as-is :/var/www/cobbler/ks_mirror/OVS-3.4.2-1384-x86_64/Server/repodata
*** TASK COMPLETE ***            <<<<<<<< This should fail if json file is bad

[root@ca-cobbler-admin links]# cobbler distro list
   OL-R5-U11-x86_64
   OL-R5-U9-x86_64
   OL-R6-U7-i386
   OL-R6-U7-x86_64
   OL-R6-U8-x86_64
   OL-R7-U2-x86_64
   OVS-3.2.11-778-x86_64
   OVS-3.3.2-1077-x86_64
   OVS-3.3.3.1085-x86_64
   OVS-3.3.4-1094-x86_64
   OVS-3.4.1-trunk-1340-x86_64
   OVS-3.4.2-1384-x86_64

thanks
[tag] [reply] [−] Comment 3 2016-09-27 11:38:51 PDT
> The error checking in cobbler for json file is not efficient as the import
> went successful and completed.

As a team, we are all in the same boat, I've been suggesting it's good idea not only to join a mailing list, but to be active there.  

Let's look into details here ... 

> [root@ca-cobbler-admin links]# cobbler import --name=OVS-3.4.2-1384-x86_64
> --arch=x86_64 --path=mnt
> task started: 2016-09-26_162146_import
> task started (id=Media import, time=Mon Sep 26 16:21:46 2016)
> Found a candidate signature: breed=ovs, version=3.4.1
> Found a matching signature: breed=ovs, version=3.4.1

Actually import command had missed to find 3.4.2 signature and it used nearest match 3.4.1  

I also see --path=mnt instead of using /mnt. It's really interesting that task has been completed.