On 07/13/2009 11:41 AM, Leonid Flaks wrote:
Brooke A. Storm wrote:
  
Great to hear thanks, I'll have to look.  The effect of the bug was that 
it killed a run of kickstarts on me when it failed a mount that was 
checked by "|| continue" which skipped the "rm -r /tmp/$rdisk" and the 
umount later on.  The bug does not affect certain types of mounts like 
LVM because anaconda doesn't try to create special files under /tmp for 
those before running mke2fs on them there (for some reason).  It does 
for a straight partition like I was using for /boot.  If your patch was 
in git for release16 before my message sent, then this may still be 
something you should consider.
 
If you look at my changes, they were simply a change from checking 
successful mount with a "|| continue" short-circuit to an if-statement 
testing the last exit code that closes just after the umount but before 
the rm -r (so the rm won't get skipped). 
 
Brooke A. Storm
System Administrator
Research IT Group, SUNY-University at Albany
p: (518) 442-3368
e: bstorm@albany.edu <mailto:bstorm@albany.edu>

------------------------------------------------------------------------
    
Michael just pushed the patch I made into the main branch. Can you check 
if it fixes the problems you had with original keep_ssh_host_keys snippet?

Thanks,

  


Note that the main branch is a development branch, so you don't want to run that in production.

Though I did apply what Leonid did verbatim and you can just download it here if you want:

http://github.com/mpdehaan/cobbler/blob/50e345ae3b77323c21e9858c8bdafdf7c9e5e5f6/snippets/keep_ssh_host_keys

--Michael