Great to hear thanks, I'll have to look.  The effect of the bug was that it killed a run of kickstarts on me when it failed a mount that was checked by "|| continue" which skipped the "rm -r /tmp/$rdisk" and the umount later on.  The bug does not affect certain types of mounts like LVM because anaconda doesn't try to create special files under /tmp for those before running mke2fs on them there (for some reason).  It does for a straight partition like I was using for /boot.  If your patch was in git for release16 before my message sent, then this may still be something you should consider.
 
If you look at my changes, they were simply a change from checking successful mount with a "|| continue" short-circuit to an if-statement testing the last exit code that closes just after the umount but before the rm -r (so the rm won't get skipped). 
 
Brooke A. Storm
System Administrator
Research IT Group, SUNY-University at Albany
p: (518) 442-3368
e: bstorm@albany.edu


From: cobbler-devel-bounces@lists.fedorahosted.org on behalf of Leonid Flaks
Sent: Fri 2009.07.10 14:27
To: cobbler development list
Subject: Re: Fix for the keep_ssh_host_keys snippet

Brooke A. Storm wrote:
> Hello all,
>
> This is my first ever post here, so forgive me if I don’t quite get how
> to go about this.  At my site, we found that the keep_ssh_host_key code
> snippet in the stable branch was causing anaconda to fail to format
> disks.  The reason is that the current version in both release16 and
> master will not clean up directories that are created if the mount
> command fails in certain ways.  I changed the check for successful mount
> to be an if statement that will allow that cleanup.  The patch file is
> attached.  I’m new to git as well, so I hope it is correctly formatted.
>

>
> Brooke A. Storm
>
> Research IT Group <ritgroup@albany.edu>
>
> University at Albany, SUNY
>
> P: 518-442-3368
>
> E: bstorm@albany.edu <mailto:bstorm@albany.edu>
>

>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> cobbler-devel mailing list
> cobbler-devel@lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/cobbler-devel

Brooke, I submitted the patch (a significant re-write) to this snippet
to the list yesterday. It actually removes all temporary directories
created - both for successful and failed mount attempts. As I understand
  in case of failed attempts they are deleted in original snippet - see
'umount' and 'rm' just before the 'done' statement. All those
directories are created in /tmp, which is not on any hard drive during
anaconda installation, but rather on the RAM. I agree that it is nice to
clean up after yourself, but I don't see the effect of leaving it behind
on partitioning. To delete all those directories, the easiest way would
be to follow every umount statement with 'rm -r /tmp/$rdisk' It is done
in my latest patch.

Did you have a chance to look at the patch I submitted? It would be nice
if you can test it in your environment to see if it solved your issue .

--

Leon
_______________________________________________
cobbler-devel mailing list
cobbler-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel