On 10/21/2009 02:01 AM, Vreman, Peter wrote:

A few comments for my successors:

I have the following list of patches for master available at http://github.com/pvreman/cobbler/commits/master/.

 

Koan:

+ afda8a88249ed3a124651a25fc52e9f78d1ab414 update string_to_hash and hash_to_string from cobblerd to support multiple kernel options with the same name

 


This should be considered for master branch.   At the time, lack of test resources prevented this from being merged to 2.0.X, though the feature should be supported for sure.

Logging improvements for background tasks:

+ 90c00b3abba0d15a2e6857469ea24fad00f95b0b make sync actions always verbose, before the copy actions were only logged without context


They should be verbose only when requested as we've had requests to keep this quiet and it is a fast operation.

+ 1a09c11eb2c546d53c366b26ab4acce96d3bc314 logging for creation of dhcp and dns configurations


Not sure it's meaningful to log this?

+ 9867963dc8eb11052ec3521c5baf18803fe826e9 log creation of pxe files


Do you mean creating PXE tree files?
I'm not sure this one is wise, as we want to cut down on logging when doing tasks that don't need it.
The files can already get pretty large and making sure log levels are appropriate and stuff is fairly important.

+ 9ee3887130fe2beb49d332a3420166398595242d log updates, add criteria to find_items and make more debug

 

CLI error handling:

+ e9d0cf90df35dd351c954c097a28ddf752edeb6b exit with error code 1 if command fails


Thought I already merged this one?   :)

+ 92ba9bb9c5594223083029cc8676b5c20d826c33 raise error in blended data if profile or system not found

 

WebUI redundant code:

+ efbc6519b34e9b9c95a9298d68fbf340b0a82c1d remove duplicate code

 

 

Regards,

Peter


This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.

_______________________________________________ cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel