On 07/14/2009 08:05 PM, Leonid Flaks wrote:
Jeff Schroeder wrote:
Please do not fork a subshell here. Use an if statement so the code is
more readable. If only there was PEP8 for bash :)
if [ $? -eq 0 ]; then
    rm -rf /tmp/$tmpdir
    continue
fi

  Seems reasonable.

 
Thanks for correction. Always good to know that the original author is watching ;-)

git diff attached.


Leon

_______________________________________________ cobbler-devel mailing list cobbler-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler-devel

Source control tip --

You might want to consider starting a branch of cobbler on github, as this allows me to just merge your tree without having to manually apply multiple patches that depend on one another.

I'd encourage everyone to check it out, really... good stuff.

--Michael