On Wed, Dec 18, 2019 at 11:10 AM Neal Gompa <ngompa13(a)gmail.com> wrote:
On Wed, Dec 18, 2019 at 12:08 PM Chris Murphy <lists(a)colorremedies.com> wrote:
>
> On Wed, Dec 18, 2019 at 10:56 AM Chris Murphy <lists(a)colorremedies.com>
wrote:
> >
> > One thing I see in the Ubuntu fstrim.service unit file that I'm not
> > seeing in the Fedora fstrim.service unit file, is a conditional for
> > containers (line 4). I'm not sure where to ask about that. Maybe
> > upstream systemd?
>
> Found it. I'm not sure if util-linux would typically be found in a
> container base image? Probably no point in calling fstrim in that
> case, but also doesn't hurt.
>
> $ sudo dnf provides /usr/lib/systemd/system/fstrim.timer
> util-linux-2.34-3.fc31.x86_64 : A collection of basic system utilities
> Repo : @System
> Matched from:
> Filename : /usr/lib/systemd/system/fstrim.timer
>
Yeah, util-linux is pretty common in some types of containers. It
probably makes sense to send a PR to add that conditional.
Appears to be in the upstream version already.
--
Chris Murphy