Hi there,
A couple of comments.
On Tue, Feb 19, 2013 at 1:58 PM, Kashyap Chamarthy <kchamart(a)redhat.com>wrote:
A couple of small additions:
- Add a PTY serial console, so that "virsh console foo" works out of
the box
(once the guest is installed).
What's the benefit of doing it this way over using the <console> XML? I
thought they would both enable the serial stuff, but maybe I'm wrong.
- Use a UNIX domain socket server (for better security) as a
character
device instead of a TCP port.
I'm not opposed to this in principle, though I think we probably need more
work to make it work properly. In particular, I'm pretty sure
"_wait_for_guest_boot" will have to be modified to listen over the unix
domain socket instead of the listen_port (at which point we can remove the
listen_port completely). You can test it out by running oz-install with -u
or -g to do customization/icicle generation, respectively.
Thanks,
Chris