On Wed, Feb 5, 2020 at 7:20 PM Tim Flink tflink@redhat.com wrote:
On Wed, 5 Feb 2020 17:52:56 +0100 Michal Srb msrb@redhat.com wrote:
Hi Tim,
On Wed, Feb 5, 2020 at 5:09 PM Tim Flink tflink@redhat.com wrote:
I'm trying to wrap up the work to get rpminspect running on all builds coming out of koji and I've run into some questions about the messages I'm emitting and what should be in resultsdb.
Do error messages (koji-build.test.error) belong in resultsdb?
I think they do.
Can you elaborate a bit more on why you think that's the case. I'm more of the mind that they don't belong in resultsdb because "error" as defined in the messaging standard isn't a test result - it's an execution state. I can't see an error state ever being used in a gating decision and thus don't see why errors should be in resultsdb.
That being said, I'm not so strongly attached to not putting them in resultsdb.
FWIW, it appears as if the all-packages pipeline's error messages are not stored in resultsdb:
https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/ci_resu...
Lines 32-36 are for production.
Michal answer is correct for the current situation, the error topic is stored in resultsdb and it is also used by Greenwave. the all-packages pipeline is also sends messages using the new format (lines 37-40), but still sends old format as well as there are components that are gating on old testcase name.
Here is an example of error message sent by the pipeline https://apps.fedoraproject.org/datagrepper/id?id=2020-5f7780c8-fbd8-46c8-9a2...
And you can see it shows in bodhi under "Automated Tests" with testcase name "fedora-ci.koji-build.tier0.functional" https://bodhi.fedoraproject.org/updates/FEDORA-2020-803c9175b9
If an error condition is reached, should both a completion (koji-build.test.complete) and an error message be emitted? I'm unclear if exiting with an error condition constitutes completion or not.
AFAIK, it's either "error" or "complete". Not both. "error" when CI couldn't finish testing from some reason and "complete" when CI finished testing successfully. Test failures still count as "complete".
That logic makes sense but there is also some sense in saying that a run is complete if it errors out.
Is that what other systems/pipelines are doing? The all-packages pipeline seems to send out both when an error condition is reached. I'm mostly not sure how other systems are reacting to the messages sent out by CI systems.
Tim
Thanks, Michal
I'd appreciate input that folks have on this.
Tim _______________________________________________ CI mailing list -- ci@lists.fedoraproject.org To unsubscribe send an email to ci-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org
CI mailing list -- ci@lists.fedoraproject.org To unsubscribe send an email to ci-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org