On Thu, Jan 13, 2022 at 6:58 PM Miroslav Vadkerti <mvadkert@redhat.com> wrote:
On Thu, Jan 13, 2022 at 6:37 PM Adam Williamson <adamwill@fedoraproject.org> wrote:
On Thu, 2022-01-13 at 18:04 +0100, Miroslav Vadkerti wrote:
>
> Well we are fine to do that change, but I will find another couple of folks
> who think the default install all is good :( So maybe we just need to be
> able to fine-tune it. We now can exclude packages from the koji build, so
> feels like we are missing the "install only these (sub)packages" scenario
> ...
>
> Can somebody give me a package where this would be handy?

Well, the question I'd have then is, who should have specified that
pipewire should be "excluded", and where? It doesn't really make sense
to expect that lorax should specify this in its test config, does it?
The fact that we had to put lorax and pipewire together in an update
was a kind of unusual and unforeseen circumstance. Because of its
nature, lorax could potentially be combined with all sorts of other
packages in an update. It's not realistic for lorax to 'know' domain-
specific test config information for any other package it could
possibly wind up bundled with in an update.

So, it'd be more sensible for pipewire to do it, but...we're still
treating gating as optional at the moment, and pipewire isn't opting
into it. So again it seems a bit odd for us to say 'hey, pipewire, you
know that CI gating thing you're not opting into? You need to carry
some configuration for it just in case anything else that does opt into
CI gating is ever bundled with pipewire in an update'.

For me, at a minimum, since the system is in general claiming to be
operating on the level of *the package* not *the update*, it should
only expressly install the subpackages of the package it claims to be
operating on. If they depend on subpackages of other packages in the
update, then of course those dependencies should be expressed and those
other subpackages will get pulled in automatically. But CI shouldn't
just be expressly installing everything in the update when it's only
claiming to be operating on one package from it.

Yep, I agree, installing both seems like an un-needed evil, so we
will prepare a repo with both in the system, but install only lorax
for the lorax run. For the pipewire we will install only pipewire,
and have lorax around in the artifact repo, makes sense to mee.

Thanks for the suggestion, let's make things better!

This should give us API support:


@msrb idea is that you will use this field to indicate which artifacts you want to skip
from installation. I will try to send a patch for this ...

/M

 

Best regards,
/M



Not expressly installing anything at all feels like a bigger step; it
might be the right thing to do, but it would definitely be a 'flag day'
kinda thing. But it seems to me that my suggestion should have a much
smaller impact.
--
Adam Williamson
Fedora QA
IRC: adamw | Twitter: adamw_ha
https://www.happyassassin.net

_______________________________________________
CI mailing list -- ci@lists.fedoraproject.org
To unsubscribe send an email to ci-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure


--
Miroslav Vadkerti :: Senior Principal QE :: Testing Farm / Linux QE
IRC mvadkert #tft #tmt #osci :: Mobile +420 773 944 252
Remote Czech Republic :: Red Hat Czech s.r.o




--
Miroslav Vadkerti :: Senior Principal QE :: Testing Farm / Linux QE
IRC mvadkert #tft #tmt #osci :: Mobile +420 773 944 252
Remote Czech Republic :: Red Hat Czech s.r.o