We don't require bash-completion. Own the completion dir(s) to ensure they are cleaned up if mock is uninstalled. ---
This is for the master branch, which doesn't own the bash-completion dirs. I didn't bump the release tag with this change, as I didn't think it would warrant a build on its own.
mock.spec | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/mock.spec b/mock.spec index 06d4f01..41c3bf2 100644 --- a/mock.spec +++ b/mock.spec @@ -183,8 +183,11 @@ pylint-3 py/mockbuild/ py/*.py py/mockbuild/plugins/* || : %defattr(0644, root, mock) %config(noreplace) %{_sysconfdir}/mock/site-defaults.cfg %if 0%{?rhel} == 6 +%dir %{_sysconfdir}/bash-completion.d %{_sysconfdir}/bash_completion.d/mock %else +%dir %{_datadir}/bash-completion +%dir %{_datadir}/bash-completion/completions %{_datadir}/bash-completion/completions/mock %{_datadir}/bash-completion/completions/mockchain %endif @@ -232,6 +235,9 @@ pylint-3 py/mockbuild/ py/*.py py/mockbuild/plugins/* || : %endif
%changelog +* Sun Nov 26 2017 Todd Zullinger tmz@pobox.com +- Own bash-completion dir(s) + * Tue Oct 31 2017 Miroslav Suchý msuchy@redhat.com 1.4.7-1 - user and group is actually not used here since some logic moved to buildroot.py - add config_opts['chrootgroup'] to site-defaults.cfg
Dne 26.11.2017 v 19:49 Todd Zullinger napsal(a):
%config(noreplace) %{_sysconfdir}/mock/site-defaults.cfg %if 0%{?rhel} == 6 +%dir %{_sysconfdir}/bash-completion.d %{_sysconfdir}/bash_completion.d/mock
I just yesterday removed this condition. In master we do not support EL6 any more. So this patch does not have sense.
Mirek
buildsys@lists.fedoraproject.org