В Пнд, 31/10/2005 в 12:02 -0500, Dan Williams пишет:
On Sun, 2005-10-30 at 21:26 +0200, Alexandr Kanevskiy wrote:
> Attached patch solves that.
Good catch. Thanks! It's been committed to HEAD and STABLE_4.
Another findings from today looking at code:
You have work_dir declared in global scope (line 847)
and use it from get_url_for_file(), line 62.
In that function will be redefining of global variable.
But expected to be local variable assignment.
Maybe rewrite that function to use _work_dir instead work_dir ?
The same thing is for 'hostname', 'cfg','port' in
or maybe it will be better that global scope code as
and put at bottom:
if __name__ == '__main__':
More funny things with work_dir, are in BuilderMock.__init__(), line
102, and in BuilderMock.run(), line 438.
I think, for BuilderMock class, all references to work_dir better to be
rewritten as "self._work_dir" ?
And few more findings in import section:
import time - listed twice.
SimpleXMLRPCServer, xmlrpclib imported, but not used.